From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10207 invoked by alias); 7 Feb 2015 23:54:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10198 invoked by uid 89); 7 Feb 2015 23:54:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: out1134-211.mail.aliyun.com Received: from out1134-211.mail.aliyun.com (HELO out1134-211.mail.aliyun.com) (42.120.134.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Feb 2015 23:54:47 +0000 X-Alimail-AntiSpam:AC=CONTINUE;BC=0.07688366|-1;FP=0|0|0|0|0|-1|-1|-1;HT=r46d02015;MF=gang.chen@sunrus.com.cn;PH=DS;RN=2;RT=2;SR=0; Received: from ShengShiZhuChengdeMacBook-Pro.local(mailfrom:gang.chen@sunrus.com.cn ip:223.72.65.13) by smtp.aliyun-inc.com(10.147.11.250); Sun, 08 Feb 2015 07:54:38 +0800 Message-ID: <54D6A794.7080107@sunrus.com.cn> Date: Sat, 07 Feb 2015 23:54:00 -0000 From: Chen Gang S User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Doug Evans CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings. References: <54D61EFC.3040000@sunrus.com.cn> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-02/txt/msg00178.txt.bz2 On 2/8/15 07:22, Doug Evans wrote: > On Sat, Feb 7, 2015 at 6:19 AM, Chen Gang S wrote: >> The related warnings: >> >> gcc -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -I. -I../../../binutils-gdb/sim/mcore -I../common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb/sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../../opcodes -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo ../../../binutils-gdb/sim/mcore/interp.c >> ../../../binutils-gdb/sim/mcore/interp.c: In function ‘handle_trap1’: >> ../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit declaration of function ‘link’ [-Wimplicit-function-declaration] >> cpu.gr[RET1] = link ((char *) a[0], (char *) a[1]); >> ^ >> ../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit declaration of function ‘access’ [-Wimplicit-function-declaration] >> cpu.gr[RET1] = access ((char *) a[0], a[1]); >> ^ >> >> 2015-02-07 Chen Gang >> >> * mcore/interp.c: Include "unistd.h" standard C header file to >> avoid compiling warnings. > > LGTM Excuse me, I am not quite familiar with the short word, I guess it is " Look Good To ME", Is what I guess correct? Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed