From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3147 invoked by alias); 8 Feb 2015 00:35:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3137 invoked by uid 89); 8 Feb 2015 00:35:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f177.google.com Received: from mail-wi0-f177.google.com (HELO mail-wi0-f177.google.com) (209.85.212.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 08 Feb 2015 00:35:51 +0000 Received: by mail-wi0-f177.google.com with SMTP id em10so2608825wid.4 for ; Sat, 07 Feb 2015 16:35:48 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.194.71.110 with SMTP id t14mr20923773wju.58.1423355748445; Sat, 07 Feb 2015 16:35:48 -0800 (PST) Received: by 10.27.20.5 with HTTP; Sat, 7 Feb 2015 16:35:48 -0800 (PST) In-Reply-To: <54D6A794.7080107@sunrus.com.cn> References: <54D61EFC.3040000@sunrus.com.cn> <54D6A794.7080107@sunrus.com.cn> Date: Sun, 08 Feb 2015 00:35:00 -0000 Message-ID: Subject: Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings. From: Doug Evans To: Chen Gang S Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00179.txt.bz2 On Sat, Feb 7, 2015 at 4:02 PM, Chen Gang S wrote: > On 2/8/15 07:22, Doug Evans wrote: >> On Sat, Feb 7, 2015 at 6:19 AM, Chen Gang S wr= ote: >>> The related warnings: >>> >>> gcc -DHAVE_CONFIG_H -DPROFILE=3D1 -DWITH_PROFILE=3D-1 -D= DEFAULT_INLINE=3D0 -I. -I../../../binutils-gdb/sim/mcore -I../= common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../= ../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb= /sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../.= ./opcodes -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo= ../../../binutils-gdb/sim/mcore/interp.c >>> ../../../binutils-gdb/sim/mcore/interp.c: In function =E2=80=98handle_t= rap1=E2=80=99: >>> ../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit decl= aration of function =E2=80=98link=E2=80=99 [-Wimplicit-function-declaration] >>> cpu.gr[RET1] =3D link ((char *) a[0], (char *) a[1]); >>> ^ >>> ../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit de= claration of function =E2=80=98access=E2=80=99 [-Wimplicit-function-declara= tion] >>> cpu.gr[RET1] =3D access ((char *) a[0], a[1]); >>> ^ >>> >>> 2015-02-07 Chen Gang >>> >>> * mcore/interp.c: Include "unistd.h" standard C header file to >>> avoid compiling warnings. >> >> LGTM > > Excuse me, I am not quite familiar with the short word, I guess it is " > Look Good To ME", > > Is what I guess correct? Looks Good To Me, yeah