From: Martin Galvan <martin.galvan@tallertechnologies.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>,
Daniel Gutson <daniel.gutson@tallertechnologies.com>
Subject: Re: [PATCH] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
Date: Wed, 27 Apr 2016 15:10:00 -0000 [thread overview]
Message-ID: <CAOKbPbboX9UGSrt3mPrBJsTU4KTmtN2r-H=z1Hgb+6RNQN2Mgg@mail.gmail.com> (raw)
In-Reply-To: <5720C0F6.9060806@redhat.com>
On Wed, Apr 27, 2016 at 10:39 AM, Pedro Alves <palves@redhat.com> wrote:
> It's better to be explicit in such cases, and say something like,
> "this has no effect currently, so can be seen as a small code
> cleanup, but once we do X, we'll print the wrong thing", or some such,
> and mention that this causes no testsuite regressions, in the
> email/commit log.
Indeed, you're right. I mentioned it in the commit log. Here's what I committed:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git&a=commit&h=476350ba4800f1144b125f6511a5e25b223cc90b
Thanks!
prev parent reply other threads:[~2016-04-27 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 21:48 Martin Galvan
2016-04-27 10:01 ` Pedro Alves
2016-04-27 13:22 ` Martin Galvan
2016-04-27 13:39 ` Pedro Alves
2016-04-27 15:10 ` Martin Galvan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOKbPbboX9UGSrt3mPrBJsTU4KTmtN2r-H=z1Hgb+6RNQN2Mgg@mail.gmail.com' \
--to=martin.galvan@tallertechnologies.com \
--cc=daniel.gutson@tallertechnologies.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox