Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Martin Galvan <martin.galvan@tallertechnologies.com>,
	       gdb-patches@sourceware.org, tom@tromey.com,
	       daniel.gutson@tallertechnologies.com
Subject: Re: [PATCH] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
Date: Wed, 27 Apr 2016 10:01:00 -0000	[thread overview]
Message-ID: <57208DFF.3020801@redhat.com> (raw)
In-Reply-To: <1461707298-26514-1-git-send-email-martin.galvan@tallertechnologies.com>

On 04/26/2016 10:48 PM, Martin Galvan wrote:
> Currently c_value_print will turn struct reference values into pointers before doing
> a set of RTTI checks. This was introduced as a fix to PR c++/15401. If there's RTTI
> the pointer will be adjusted and converted back to a reference. However, if there's
> no RTTI the value will still be treated as a pointer during the remainder of the function.
> This patch moves the conversion down so that it's always performed when needed.

What's the motivation behind this?  Does it change anything user visible?

Thanks,
Pedro Alves


  reply	other threads:[~2016-04-27 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 21:48 Martin Galvan
2016-04-27 10:01 ` Pedro Alves [this message]
2016-04-27 13:22   ` Martin Galvan
2016-04-27 13:39     ` Pedro Alves
2016-04-27 15:10       ` Martin Galvan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57208DFF.3020801@redhat.com \
    --to=palves@redhat.com \
    --cc=daniel.gutson@tallertechnologies.com \
    --cc=gdb-patches@sourceware.org \
    --cc=martin.galvan@tallertechnologies.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox