From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94332 invoked by alias); 27 Apr 2016 10:01:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94318 invoked by uid 89); 27 Apr 2016 10:01:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Apr 2016 10:01:38 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 12F51C062CE7; Wed, 27 Apr 2016 10:01:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3RA1ZUq015214; Wed, 27 Apr 2016 06:01:35 -0400 Subject: Re: [PATCH] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT To: Martin Galvan , gdb-patches@sourceware.org, tom@tromey.com, daniel.gutson@tallertechnologies.com References: <1461707298-26514-1-git-send-email-martin.galvan@tallertechnologies.com> From: Pedro Alves Message-ID: <57208DFF.3020801@redhat.com> Date: Wed, 27 Apr 2016 10:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1461707298-26514-1-git-send-email-martin.galvan@tallertechnologies.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00576.txt.bz2 On 04/26/2016 10:48 PM, Martin Galvan wrote: > Currently c_value_print will turn struct reference values into pointers before doing > a set of RTTI checks. This was introduced as a fix to PR c++/15401. If there's RTTI > the pointer will be adjusted and converted back to a reference. However, if there's > no RTTI the value will still be treated as a pointer during the remainder of the function. > This patch moves the conversion down so that it's always performed when needed. What's the motivation behind this? Does it change anything user visible? Thanks, Pedro Alves