From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131225-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 107911 invoked by alias); 27 Apr 2016 15:10:59 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 107892 invoked by uid 89); 27 Apr 2016 15:10:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail-qg0-f51.google.com
Received: from mail-qg0-f51.google.com (HELO mail-qg0-f51.google.com) (209.85.192.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 27 Apr 2016 15:10:48 +0000
Received: by mail-qg0-f51.google.com with SMTP id d90so18248451qgd.3        for <gdb-patches@sourceware.org>; Wed, 27 Apr 2016 08:10:48 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=CtWe9m386jU7vaQFw1HVHhcqG04Rx53MyGFtUBh06Tg=;        b=JQhwW8SRGxhI306WSGG8GHQs6Hz+mpWVRUGPQfyzn1T0uFWazkMA+wbSNa32gcDun/         0m2KVngzXc1eE9TWjvY2dGCcsgu85H5KqUoDy/la2SXoTTJsiJzkEYAHj/XC6SFpi+sI         9SipRBlg6tw4kM+lo52k3EHh76k4yHxMB7Avzg6d2TTHaNfXi6tN8e0pw1G0090ikWU0         MEsteEdn7CjSG898sr+OA5COhF9X588wzZIAWRUe+RyW3tjeRmFPMv72dSDCXbt2VDBi         xlPLZkhr9axjZsnKPjuaU6r5c+tPwhJg1I3+H3eWrKEelpaVdhdGKoMEzB5d/zqCu3OE         0jwQ==
X-Gm-Message-State: AOPr4FXG2PN3rIh0VeOu96rn///7RdpMOJNoSrS4PhSWMomMALNLPAtT+ml5Rb2f9LdtjvCTfZOJ4HOL6NQzv7GI
X-Received: by 10.140.109.132 with SMTP id l4mr4189466qgf.9.1461769846719; Wed, 27 Apr 2016 08:10:46 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.55.24.134 with HTTP; Wed, 27 Apr 2016 08:10:07 -0700 (PDT)
In-Reply-To: <5720C0F6.9060806@redhat.com>
References: <1461707298-26514-1-git-send-email-martin.galvan@tallertechnologies.com> <57208DFF.3020801@redhat.com> <CAOKbPbY_NuRyB_HJsLHLJjXT_UsSWFJxwuVpdxxUnLFxkBvSLQ@mail.gmail.com> <5720C0F6.9060806@redhat.com>
From: Martin Galvan <martin.galvan@tallertechnologies.com>
Date: Wed, 27 Apr 2016 15:10:00 -0000
Message-ID: <CAOKbPbboX9UGSrt3mPrBJsTU4KTmtN2r-H=z1Hgb+6RNQN2Mgg@mail.gmail.com>
Subject: Re: [PATCH] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, Tom Tromey <tom@tromey.com>, 	Daniel Gutson <daniel.gutson@tallertechnologies.com>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2016-04/txt/msg00597.txt.bz2

On Wed, Apr 27, 2016 at 10:39 AM, Pedro Alves <palves@redhat.com> wrote:
> It's better to be explicit in such cases, and say something like,
> "this has no effect currently, so can be seen as a small code
> cleanup, but once we do X, we'll print the wrong thing", or some such,
> and mention that this causes no testsuite regressions, in the
> email/commit log.

Indeed, you're right. I mentioned it in the commit log. Here's what I committed:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git&a=commit&h=476350ba4800f1144b125f6511a5e25b223cc90b

Thanks!