From: Martin Galvan <martin.galvan@tallertechnologies.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Pedro Alves <palves@redhat.com>,
gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] value: Make accessor methods' parameters const-correct
Date: Thu, 07 Apr 2016 13:50:00 -0000 [thread overview]
Message-ID: <CAOKbPbaq4J8E=-qwezZF_hQ4-mWkyVQW=CmeeLkMfVTNPD+Q+g@mail.gmail.com> (raw)
In-Reply-To: <570662E0.1020500@ericsson.com>
On Thu, Apr 7, 2016 at 10:38 AM, Simon Marchi <simon.marchi@ericsson.com> wrote:
> And to be pedantic, if you want to make all arguments const you should also do this :)
>
> -set_value_bitpos (struct value *value, int bit)
> +set_value_bitpos (struct value *const value, const int bit)
Yeah, I thought of that but it'd been too much. Thanks for the
feedback guys, I'll be sending v2 in a moment.
Btw, while I was looking through value.c I saw many functions whose
names are 'deprecated', or 'hack', yet they're still being used. If
you guys want I can look into removing/replacing them after I'm done
with the synthetic reference fixes.
next prev parent reply other threads:[~2016-04-07 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 20:36 Martin Galvan
2016-04-06 23:36 ` Pedro Alves
2016-04-07 13:32 ` Martin Galvan
2016-04-07 13:33 ` Pedro Alves
2016-04-07 13:38 ` Simon Marchi
2016-04-07 13:50 ` Martin Galvan [this message]
2016-04-07 14:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOKbPbaq4J8E=-qwezZF_hQ4-mWkyVQW=CmeeLkMfVTNPD+Q+g@mail.gmail.com' \
--to=martin.galvan@tallertechnologies.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox