From: Martin Galvan <martin.galvan@tallertechnologies.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] value: Make accessor methods' parameters const-correct
Date: Thu, 07 Apr 2016 13:32:00 -0000 [thread overview]
Message-ID: <CAOKbPbYfNmNjJ8mc4mm7WDweNYP=Wu2eOdH+_jDm7rirZWoWUQ@mail.gmail.com> (raw)
In-Reply-To: <57059D83.2010403@redhat.com>
On Wed, Apr 6, 2016 at 8:36 PM, Pedro Alves <palves@redhat.com> wrote:
> Const on pointer parameters is certainly useful. But since you asked
> me [ :-) ], I'm on the "const on value params is mostly useless
> clutter" camp. It's something you don't see many style guides requiring,
> and it's something gdb hasn't been doing either.
>
> So personally I'd prefer a patch without those bits.
No problem, I'll remove them. Can I commit the patch after I do it, or
should I send in a v2 first?
next prev parent reply other threads:[~2016-04-07 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 20:36 Martin Galvan
2016-04-06 23:36 ` Pedro Alves
2016-04-07 13:32 ` Martin Galvan [this message]
2016-04-07 13:33 ` Pedro Alves
2016-04-07 13:38 ` Simon Marchi
2016-04-07 13:50 ` Martin Galvan
2016-04-07 14:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOKbPbYfNmNjJ8mc4mm7WDweNYP=Wu2eOdH+_jDm7rirZWoWUQ@mail.gmail.com' \
--to=martin.galvan@tallertechnologies.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox