From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55992 invoked by alias); 7 Apr 2016 13:32:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55973 invoked by uid 89); 7 Apr 2016 13:32:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:560 X-HELO: mail-qg0-f50.google.com Received: from mail-qg0-f50.google.com (HELO mail-qg0-f50.google.com) (209.85.192.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 07 Apr 2016 13:31:50 +0000 Received: by mail-qg0-f50.google.com with SMTP id c6so62772820qga.1 for ; Thu, 07 Apr 2016 06:31:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XDwidQY6uI0Va1VecZY4kok6zrFzdAX0Sn8dEJX9xT4=; b=kWKzSoEQ1Rx/QIh69qzQTFw3wejarLLIDrROkMFtCGKCFnF4QwT2Xwy0lYw1AyWSLu PhAwIzGCJxmkIl4YTSwlV9ul9trHqG9VY3J7OFIjeuLthuAwJoetjA2hcTxKz+ZM989W /76pi2qwlP9b0RuyOKe4hs3PaPA71O4w/37LjUV8DL3U04ClzLGWreE4Jz9ONvi4psux NlquxBTo/J62nbFdDv/jiqKqUKy41kH5PoFbrL2FBJa42YaTpmY9PirzBAoFlblYJqXS XHJpCHsPIkiAJJjQAY9N2RH/OJmqftlhgV0TmINGlMclN5dJUWMwa4x5c91o1jLGONW+ 94FQ== X-Gm-Message-State: AD7BkJJgv0WEBb9JAUMdXdqhJjIyRvRdSgt93ghnFHgOnEoPwVPMqdfSuUorPHLjx1EZkIk/w2t0QOB+7XVMowyp X-Received: by 10.140.86.112 with SMTP id o103mr3774445qgd.9.1460035908662; Thu, 07 Apr 2016 06:31:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.192.12 with HTTP; Thu, 7 Apr 2016 06:31:08 -0700 (PDT) In-Reply-To: <57059D83.2010403@redhat.com> References: <1459974933-616-1-git-send-email-martin.galvan@tallertechnologies.com> <57059D83.2010403@redhat.com> From: Martin Galvan Date: Thu, 07 Apr 2016 13:32:00 -0000 Message-ID: Subject: Re: [PATCH] value: Make accessor methods' parameters const-correct To: Pedro Alves Cc: gdb-patches , Tom Tromey Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-04/txt/msg00149.txt.bz2 On Wed, Apr 6, 2016 at 8:36 PM, Pedro Alves wrote: > Const on pointer parameters is certainly useful. But since you asked > me [ :-) ], I'm on the "const on value params is mostly useless > clutter" camp. It's something you don't see many style guides requiring, > and it's something gdb hasn't been doing either. > > So personally I'd prefer a patch without those bits. No problem, I'll remove them. Can I commit the patch after I do it, or should I send in a v2 first?