From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45932 invoked by alias); 7 Apr 2016 13:50:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45855 invoked by uid 89); 7 Apr 2016 13:50:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qg0-f50.google.com Received: from mail-qg0-f50.google.com (HELO mail-qg0-f50.google.com) (209.85.192.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 07 Apr 2016 13:50:00 +0000 Received: by mail-qg0-f50.google.com with SMTP id f52so63301625qga.3 for ; Thu, 07 Apr 2016 06:50:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MOUCe4gyamWaQyGRs10T5phLOBEaRT4/blBJnc42ksM=; b=POdZ+rOm6eIArem6gz5sjEhWj4tjfeoOfbiIsGuU3m+jDop36GqS6CJlPnZ75V/iN9 2DNYvFbpJpAPsEh+9V8Nrkr6cAOb5ieAjVBLfN3Jxs8i5gjKLvgQn/sgDrX8tsnmnHkz w9wgPlvgt3D4s2lq+84OelCiyZIceFS1f6OiWNISZSY89GBiERycZe6T6UJaAdOwMcCx E74BDYGnn8GoSpHLltfSS3P4wBWGCKZL7Pnpkawt/qx6GGwS+HKYdtdrs8xXZOxJkfO8 NKhAaEYYIOGd9YxiwsUqcoLy2ks2BLNTK8QlJ3iv2UEcN1IPR+DfPN4pOSvKMVCWHAVh rW/w== X-Gm-Message-State: AD7BkJJ72XrRkqGlQPKMMreGu260gFbfhJvO4DivLAF7uYA9IVtmJDLbbh4+libDG0X2y6nK1CyFeBdhjgOolqWi X-Received: by 10.140.39.138 with SMTP id v10mr3762457qgv.82.1460036998786; Thu, 07 Apr 2016 06:49:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.192.12 with HTTP; Thu, 7 Apr 2016 06:49:19 -0700 (PDT) In-Reply-To: <570662E0.1020500@ericsson.com> References: <1459974933-616-1-git-send-email-martin.galvan@tallertechnologies.com> <57059D83.2010403@redhat.com> <570662E0.1020500@ericsson.com> From: Martin Galvan Date: Thu, 07 Apr 2016 13:50:00 -0000 Message-ID: Subject: Re: [PATCH] value: Make accessor methods' parameters const-correct To: Simon Marchi Cc: Pedro Alves , gdb-patches , Tom Tromey Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-04/txt/msg00152.txt.bz2 On Thu, Apr 7, 2016 at 10:38 AM, Simon Marchi wrote: > And to be pedantic, if you want to make all arguments const you should also do this :) > > -set_value_bitpos (struct value *value, int bit) > +set_value_bitpos (struct value *const value, const int bit) Yeah, I thought of that but it'd been too much. Thanks for the feedback guys, I'll be sending v2 in a moment. Btw, while I was looking through value.c I saw many functions whose names are 'deprecated', or 'hack', yet they're still being used. If you guys want I can look into removing/replacing them after I'm done with the synthetic reference fixes.