Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org, Hui Zhu <hui_zhu@mentor.com>
Subject: Re: [RFC] Autoload-breakpoints new version [3/9] notification async
Date: Thu, 23 Aug 2012 14:30:00 -0000	[thread overview]
Message-ID: <CANFwon1hGpwPHwKDuJQdFwcWuO4U4FjLrDkM__5AqLLO1Xmymw@mail.gmail.com> (raw)
In-Reply-To: <50362619.6030505@codesourcery.com>

On Thu, Aug 23, 2012 at 8:46 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 08/15/2012 10:22 PM, Hui Zhu wrote:
>>
>>   struct stop_reply;
>> @@ -1297,6 +1302,7 @@ enum {
>>     PACKET_QDisableRandomization,
>>     PACKET_QAgent,
>>     PACKET_AutoloadBreakpoints,
>> +  PACKET_NotificationAsync,
>>     PACKET_MAX
>>   };
>>
>> @@ -3998,6 +4004,8 @@ static struct protocol_feature remote_pr
>>       remote_string_tracing_feature, -1 },
>>     { "AutoloadBreakpoints", PACKET_DISABLE, remote_supported_packet,
>>       PACKET_AutoloadBreakpoints },
>> +  { "NotificationAsync", PACKET_DISABLE, remote_supported_packet,
>> +    PACKET_NotificationAsync },
>>   };
>
>
> Hui,
> As we discussed in this thread,
>
>   Re: [RFC] Autoload-breakpoints new version [3/9] notification async
>   http://sourceware.org/ml/gdb-patches/2012-08/msg00337.html
>
> "NotificationAsync" is not needed anymore, so your patch should be updated
> to reflect this.
>
> --
> Yao

Hi Yao,

1. We still not sure keep the support packet "NotificationAsync" is
good or not.
2. Even if we don't need support packet "NotificationAsync".  The
notification still need the extend for async.

So if you don't mind, I suggest you keep review this patch.  And after
I got your comments, I update a new one.

Thanks,
Hui


      reply	other threads:[~2012-08-23 14:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  7:10 Hui Zhu
2012-08-08 13:26 ` Yao Qi
2012-08-11 15:20   ` Hui Zhu
2012-08-13  2:25     ` Yao Qi
2012-08-14 12:01       ` Hui Zhu
2012-08-15 14:23         ` Hui Zhu
2012-08-23 10:44           ` Hui Zhu
2012-08-23 11:20             ` Pedro Alves
2012-08-23 12:46           ` Yao Qi
2012-08-23 14:30             ` Hui Zhu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANFwon1hGpwPHwKDuJQdFwcWuO4U4FjLrDkM__5AqLLO1Xmymw@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hui_zhu@mentor.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox