Re: [RFC] Autoload-breakpoints new version [3/9] notification async

[Hui Zhu <teawater@gmail.com>]

On Wed, Aug 15, 2012 at 10:22 PM, Hui Zhu <teawater@gmail.com> wrote:
> On Tue, Aug 14, 2012 at 8:01 PM, Hui Zhu <teawater@gmail.com> wrote:
>> On Mon, Aug 13, 2012 at 10:24 AM, Yao Qi <yao@codesourcery.com> wrote:
>>> On 08/11/2012 11:19 PM, Hui Zhu wrote:
>>>>>
>>>>> >
>>>>> >I applied patch 1/9 and 3/9, and get following regressions in gdbserver
>>>>> > with
>>>>> >async mode on.
>>>>> >
>>>>> >   FAIL: gdb.mi/mi-nonstop-exit.exp: finished exec continue (unknown
>>>>> > output
>>>>> >after running)
>>>>> >   FAIL: gdb.mi/mi-nonstop-exit.exp: finished exec continue (2) (unknown
>>>>> > output
>>>>> >after running)
>>>>> >   FAIL: gdb.mi/mi-nsmoribund.exp: resume all, waiting for program exit
>>>>> >(timeout)
>>>>
>>>> My part is OK, Could you tell me how do you do the test?
>>>>
>>>
>>> In gdb build dir, add the following line into testsuite/site.exp
>>>
>>>   set GDBFLAGS "-ex \"set target-async on\""
>>>
>>> make check RUNTESTFLAGS="--target_board=native-gdbserver"
>>>
>>> or you can set GDBFLAGS in your own board file other than testuite/site.exp.
>>>
>>> --
>>> Yao
>>
>> Hi guys,
>>
>> I found this issue is because notification "Stop:" cannot be handled
>> in async handler.
>> What I thought is push it back a buffer and let GDB  handle it later
>> that GDB in right status to handle it.
>>
>> I didn't have other good idea on this issue is because I cannot
>> reproduce it in command line.
>>
>> Do you have some comments on this issue?
>>
>> Thanks,
>> Hui
>
> Hi,
>
> I done a new version to handle this issue.
> Because readchar will throw error and pop_target directly in remote.c.
> So I change it use another way to handle it.  Not sure it is good or
> not.  But it make test can be passed.
>
> Thanks,
> Hui

Hi Pedro,

You reviewed the prev version of this patch that named report-async.
Now, I gived up the report-async and just extend the notification for
the function.

So could you help me with it?  Thanks a lot.

Best,
Hui