From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13739 invoked by alias); 23 Aug 2012 10:44:49 -0000 Received: (qmail 13729 invoked by uid 22791); 23 Aug 2012 10:44:48 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Aug 2012 10:44:35 +0000 Received: by pbbro12 with SMTP id ro12so1203099pbb.0 for ; Thu, 23 Aug 2012 03:44:35 -0700 (PDT) Received: by 10.68.223.164 with SMTP id qv4mr3703054pbc.20.1345718675179; Thu, 23 Aug 2012 03:44:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.239.132 with HTTP; Thu, 23 Aug 2012 03:43:55 -0700 (PDT) In-Reply-To: References: <5020BF3A.8030809@mentor.com> <1866631.Ri6KkAT9H2@qiyao.dyndns.org> <50286552.1090003@codesourcery.com> From: Hui Zhu Date: Thu, 23 Aug 2012 10:44:00 -0000 Message-ID: Subject: Re: [RFC] Autoload-breakpoints new version [3/9] notification async To: Pedro Alves Cc: gdb-patches@sourceware.org, Hui Zhu , Yao Qi Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00648.txt.bz2 On Wed, Aug 15, 2012 at 10:22 PM, Hui Zhu wrote: > On Tue, Aug 14, 2012 at 8:01 PM, Hui Zhu wrote: >> On Mon, Aug 13, 2012 at 10:24 AM, Yao Qi wrote: >>> On 08/11/2012 11:19 PM, Hui Zhu wrote: >>>>> >>>>> > >>>>> >I applied patch 1/9 and 3/9, and get following regressions in gdbserver >>>>> > with >>>>> >async mode on. >>>>> > >>>>> > FAIL: gdb.mi/mi-nonstop-exit.exp: finished exec continue (unknown >>>>> > output >>>>> >after running) >>>>> > FAIL: gdb.mi/mi-nonstop-exit.exp: finished exec continue (2) (unknown >>>>> > output >>>>> >after running) >>>>> > FAIL: gdb.mi/mi-nsmoribund.exp: resume all, waiting for program exit >>>>> >(timeout) >>>> >>>> My part is OK, Could you tell me how do you do the test? >>>> >>> >>> In gdb build dir, add the following line into testsuite/site.exp >>> >>> set GDBFLAGS "-ex \"set target-async on\"" >>> >>> make check RUNTESTFLAGS="--target_board=native-gdbserver" >>> >>> or you can set GDBFLAGS in your own board file other than testuite/site.exp. >>> >>> -- >>> Yao >> >> Hi guys, >> >> I found this issue is because notification "Stop:" cannot be handled >> in async handler. >> What I thought is push it back a buffer and let GDB handle it later >> that GDB in right status to handle it. >> >> I didn't have other good idea on this issue is because I cannot >> reproduce it in command line. >> >> Do you have some comments on this issue? >> >> Thanks, >> Hui > > Hi, > > I done a new version to handle this issue. > Because readchar will throw error and pop_target directly in remote.c. > So I change it use another way to handle it. Not sure it is good or > not. But it make test can be passed. > > Thanks, > Hui Hi Pedro, You reviewed the prev version of this patch that named report-async. Now, I gived up the report-async and just extend the notification for the function. So could you help me with it? Thanks a lot. Best, Hui