From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94032-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13548 invoked by alias); 23 Aug 2012 14:30:56 -0000
Received: (qmail 13535 invoked by uid 22791); 23 Aug 2012 14:30:55 -0000
X-SWARE-Spam-Status: No, hits=-4.7 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Aug 2012 14:30:40 +0000
Received: by vcbfl10 with SMTP id fl10so1009166vcb.0        for <gdb-patches@sourceware.org>; Thu, 23 Aug 2012 07:30:40 -0700 (PDT)
Received: by 10.52.95.165 with SMTP id dl5mr1218339vdb.23.1345732239991; Thu, 23 Aug 2012 07:30:39 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.42.66 with HTTP; Thu, 23 Aug 2012 07:29:59 -0700 (PDT)
In-Reply-To: <50362619.6030505@codesourcery.com>
References: <5020BF3A.8030809@mentor.com> <1866631.Ri6KkAT9H2@qiyao.dyndns.org> <CANFwon3V45sQZVn-5tmzuByZQPnSwW9YQmRaNhZY=iFgLTAvsA@mail.gmail.com> <50286552.1090003@codesourcery.com> <CANFwon0h9uSMHBHGfEoFHJBhCqSy-0MMd-L-pG8EUcFjn+_+1Q@mail.gmail.com> <CANFwon1XhnmWaqmxyhCgtHjNPM9rYAoUDPAfMZFkENJ-UgzVuA@mail.gmail.com> <50362619.6030505@codesourcery.com>
From: Hui Zhu <teawater@gmail.com>
Date: Thu, 23 Aug 2012 14:30:00 -0000
Message-ID: <CANFwon1hGpwPHwKDuJQdFwcWuO4U4FjLrDkM__5AqLLO1Xmymw@mail.gmail.com>
Subject: Re: [RFC] Autoload-breakpoints new version [3/9] notification async
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org, Hui Zhu <hui_zhu@mentor.com>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00661.txt.bz2

On Thu, Aug 23, 2012 at 8:46 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 08/15/2012 10:22 PM, Hui Zhu wrote:
>>
>>   struct stop_reply;
>> @@ -1297,6 +1302,7 @@ enum {
>>     PACKET_QDisableRandomization,
>>     PACKET_QAgent,
>>     PACKET_AutoloadBreakpoints,
>> +  PACKET_NotificationAsync,
>>     PACKET_MAX
>>   };
>>
>> @@ -3998,6 +4004,8 @@ static struct protocol_feature remote_pr
>>       remote_string_tracing_feature, -1 },
>>     { "AutoloadBreakpoints", PACKET_DISABLE, remote_supported_packet,
>>       PACKET_AutoloadBreakpoints },
>> +  { "NotificationAsync", PACKET_DISABLE, remote_supported_packet,
>> +    PACKET_NotificationAsync },
>>   };
>
>
> Hui,
> As we discussed in this thread,
>
>   Re: [RFC] Autoload-breakpoints new version [3/9] notification async
>   http://sourceware.org/ml/gdb-patches/2012-08/msg00337.html
>
> "NotificationAsync" is not needed anymore, so your patch should be updated
> to reflect this.
>
> --
> Yao

Hi Yao,

1. We still not sure keep the support packet "NotificationAsync" is
good or not.
2. Even if we don't need support packet "NotificationAsync".  The
notification still need the extend for async.

So if you don't mind, I suggest you keep review this patch.  And after
I got your comments, I update a new one.

Thanks,
Hui