Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add extern of output_command to utils.h
Date: Fri, 04 Jan 2013 09:04:00 -0000	[thread overview]
Message-ID: <CANFwon1fZ0nP0rr10MDJmr7gJYqoDKiXsDAp8w=4iFU5MbekfQ@mail.gmail.com> (raw)
In-Reply-To: <87d2xm0wrs.fsf@fleche.redhat.com>

On Fri, Jan 4, 2013 at 5:41 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui>    * tracepoint.c: Remove extern of function output_command.
> Hui>    * utils.h (output_command): New extern.
>
> I appreciate you doing this, but utils.h seems like a weird place to put
> this.
>
> I don't know of a better place but I suppose if I were doing it, I would
> look for a header that, ideally, is both printing-related and already
> has some _command declarations in it.
>
> Tom

Hi Tom,

What about add this extern to valprint.h that is included by printcmd.c?

Thanks,
Hui


  reply	other threads:[~2013-01-04  9:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 12:21 Hui Zhu
2013-01-03 21:41 ` Tom Tromey
2013-01-04  9:04   ` Hui Zhu [this message]
2013-01-04 14:45     ` Tom Tromey
2013-01-05  5:37       ` Hui Zhu
2013-01-06  6:50         ` Joel Brobecker
2013-01-06  7:33           ` Hui Zhu
2013-01-07 15:08             ` Tom Tromey
2013-01-07 15:12               ` Pierre Muller
     [not found]               ` <50eae5d4.e606c20a.75af.fffffc7eSMTPIN_ADDED_BROKEN@mx.google.com>
2013-01-08  2:02                 ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANFwon1fZ0nP0rr10MDJmr7gJYqoDKiXsDAp8w=4iFU5MbekfQ@mail.gmail.com' \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox