From: Joel Brobecker <brobecker@adacore.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add extern of output_command to utils.h
Date: Sun, 06 Jan 2013 06:50:00 -0000 [thread overview]
Message-ID: <20130106065027.GB3703@adacore.com> (raw)
In-Reply-To: <CANFwon2pVusoP15YcaOR63vcDz8yeCB97xpH14pgZaXwbgCBqQ@mail.gmail.com>
> 2013-01-05 Hui Zhu <hui_zhu@mentor.com>
>
> * tracepoint.c: Remove extern of function output_command.
> * valprint.h.h (output_command): New extern.
If I may, can we try to provide the names of the arguments
in function declarations?
> --- a/valprint.h
> +++ b/valprint.h
> @@ -205,4 +205,6 @@ extern void generic_printstr (struct ui_
> int quote_char, int c_style_terminator,
> const struct value_print_options *options);
>
> +extern void output_command (char *, int);
> +
Thanks,
--
Joel
next prev parent reply other threads:[~2013-01-06 6:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 12:21 Hui Zhu
2013-01-03 21:41 ` Tom Tromey
2013-01-04 9:04 ` Hui Zhu
2013-01-04 14:45 ` Tom Tromey
2013-01-05 5:37 ` Hui Zhu
2013-01-06 6:50 ` Joel Brobecker [this message]
2013-01-06 7:33 ` Hui Zhu
2013-01-07 15:08 ` Tom Tromey
2013-01-07 15:12 ` Pierre Muller
[not found] ` <50eae5d4.e606c20a.75af.fffffc7eSMTPIN_ADDED_BROKEN@mx.google.com>
2013-01-08 2:02 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130106065027.GB3703@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox