From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97452-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26061 invoked by alias); 6 Jan 2013 06:50:39 -0000
Received: (qmail 26053 invoked by uid 22791); 6 Jan 2013 06:50:38 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Jan 2013 06:50:34 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id D9E402E3ED;	Sun,  6 Jan 2013 01:50:33 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id Ed8te4db+XoP; Sun,  6 Jan 2013 01:50:33 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 5EA6F2E188;	Sun,  6 Jan 2013 01:50:33 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000)	id 858CCC23AD; Sun,  6 Jan 2013 10:50:27 +0400 (RET)
Date: Sun, 06 Jan 2013 06:50:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>,	gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add extern of output_command to utils.h
Message-ID: <20130106065027.GB3703@adacore.com>
References: <CANFwon27w-6+73nUvm-RYip2Ku8JcGRkVzJVwNrWOzsij6ES8A@mail.gmail.com> <87d2xm0wrs.fsf@fleche.redhat.com> <CANFwon1fZ0nP0rr10MDJmr7gJYqoDKiXsDAp8w=4iFU5MbekfQ@mail.gmail.com> <87obh5ypk7.fsf@fleche.redhat.com> <CANFwon2pVusoP15YcaOR63vcDz8yeCB97xpH14pgZaXwbgCBqQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANFwon2pVusoP15YcaOR63vcDz8yeCB97xpH14pgZaXwbgCBqQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00082.txt.bz2

> 2013-01-05  Hui Zhu  <hui_zhu@mentor.com>
> 
> 	* tracepoint.c: Remove extern of function output_command.
> 	* valprint.h.h (output_command): New extern.

If I may, can we try to provide the names of the arguments
in function declarations?

> --- a/valprint.h
> +++ b/valprint.h
> @@ -205,4 +205,6 @@ extern void generic_printstr (struct ui_
>  			      int quote_char, int c_style_terminator,
>  			      const struct value_print_options *options);
> 
> +extern void output_command (char *, int);
> +

Thanks,
-- 
Joel