From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6260 invoked by alias); 4 Jan 2013 09:04:22 -0000 Received: (qmail 6246 invoked by uid 22791); 4 Jan 2013 09:04:21 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-oa0-f51.google.com (HELO mail-oa0-f51.google.com) (209.85.219.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jan 2013 09:04:15 +0000 Received: by mail-oa0-f51.google.com with SMTP id n12so14947925oag.10 for ; Fri, 04 Jan 2013 01:04:14 -0800 (PST) Received: by 10.60.4.165 with SMTP id l5mr30056009oel.84.1357290254809; Fri, 04 Jan 2013 01:04:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.84.5 with HTTP; Fri, 4 Jan 2013 01:03:34 -0800 (PST) In-Reply-To: <87d2xm0wrs.fsf@fleche.redhat.com> References: <87d2xm0wrs.fsf@fleche.redhat.com> From: Hui Zhu Date: Fri, 04 Jan 2013 09:04:00 -0000 Message-ID: Subject: Re: [PATCH] Add extern of output_command to utils.h To: Tom Tromey Cc: gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00063.txt.bz2 On Fri, Jan 4, 2013 at 5:41 AM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> * tracepoint.c: Remove extern of function output_command. > Hui> * utils.h (output_command): New extern. > > I appreciate you doing this, but utils.h seems like a weird place to put > this. > > I don't know of a better place but I suppose if I were doing it, I would > look for a header that, ideally, is both printing-related and already > has some _command declarations in it. > > Tom Hi Tom, What about add this extern to valprint.h that is included by printcmd.c? Thanks, Hui