From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Make test-cp-name-parser usable
Date: Wed, 03 Aug 2011 20:37:00 -0000 [thread overview]
Message-ID: <CAN9gPaGa+Uc2Yb3HngQwNHh00kJXZQhMFf4Udxv7xAs1zYb6HQ@mail.gmail.com> (raw)
In-Reply-To: <20110802170152.GA24932@host1.jankratochvil.net>
On Tue, Aug 2, 2011 at 1:01 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> gdb/
> 2011-08-02 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * cp-name-parser.y (xfree): Remove the call of free.
> (main): Uncomment "Demangling error\n".
OK.
> --- a/gdb/cp-name-parser.y
> +++ b/gdb/cp-name-parser.y
> @@ -2036,13 +2036,12 @@ trim_chars (char *lexptr, char **extra_chars)
> }
>
> /* When this file is built as a standalone program, xmalloc comes from
> - libiberty --- in which case we have to provide xfree ourselves. */
> + libiberty --- in which case we have to provide xfree ourselves.
> + A call to free would get translated xfree back again. Leak is OK. */
"translated back to xfree again"
What does the translation - is it as simple as #undef free or (free) (ptr)?
--
Thanks,
Daniel
next prev parent reply other threads:[~2011-08-03 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 17:02 Jan Kratochvil
2011-08-03 20:37 ` Daniel Jacobowitz [this message]
2011-08-03 20:56 ` Tom Tromey
2011-08-04 9:51 ` Jan Kratochvil
2011-08-05 20:19 ` Daniel Jacobowitz
2011-08-06 14:15 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN9gPaGa+Uc2Yb3HngQwNHh00kJXZQhMFf4Udxv7xAs1zYb6HQ@mail.gmail.com \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox