Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Make test-cp-name-parser usable
Date: Sat, 06 Aug 2011 14:15:00 -0000	[thread overview]
Message-ID: <20110806141441.GA2668@host1.jankratochvil.net> (raw)
In-Reply-To: <CAN9gPaH8swWWoxBChAHY2FComG5vmQRKrsXz5huNUNiFYQGu=Q@mail.gmail.com>

On Fri, 05 Aug 2011 22:18:50 +0200, Daniel Jacobowitz wrote:
> Thanks!  I appreciate it.  You might want an explanatory comment, this
> looks sufficiently odd.  It's OK with me either way.

Checked in with the comment.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-08/msg00036.html

--- src/gdb/ChangeLog	2011/08/05 16:38:34	1.13256
+++ src/gdb/ChangeLog	2011/08/06 14:13:48	1.13257
@@ -1,3 +1,8 @@
+2011-08-06  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* cp-name-parser.y (xfree): Wrap the name free by CONCAT2.
+	(main): Uncomment "Demangling error\n".
+
 2011-08-05  Paul Pluzhnikov  <ppluzhnikov@google.com>
 
 	* solib-target.c (segment_attributes): Make them static.
--- src/gdb/cp-name-parser.y	2011/03/18 13:51:41	1.20
+++ src/gdb/cp-name-parser.y	2011/08/06 14:13:49	1.21
@@ -2042,7 +2042,10 @@
 xfree (void *ptr)
 {
   if (ptr != NULL)
-    free (ptr);
+    {
+      /* Literal `free' would get translated back to xfree again.  */
+      CONCAT2 (fr,ee) (ptr);
+    }
 }
 
 int
@@ -2071,7 +2074,7 @@
 	str2 = cplus_demangle (buf, DMGL_PARAMS | DMGL_ANSI | DMGL_VERBOSE);
 	if (str2 == NULL)
 	  {
-	    /* printf ("Demangling error\n"); */
+	    printf ("Demangling error\n");
 	    if (c)
 	      printf ("%s%c%s\n", buf, c, extra_chars);
 	    else


      reply	other threads:[~2011-08-06 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 17:02 Jan Kratochvil
2011-08-03 20:37 ` Daniel Jacobowitz
2011-08-03 20:56   ` Tom Tromey
2011-08-04  9:51     ` Jan Kratochvil
2011-08-05 20:19       ` Daniel Jacobowitz
2011-08-06 14:15         ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110806141441.GA2668@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox