From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 787 invoked by alias); 6 Aug 2011 14:15:09 -0000 Received: (qmail 777 invoked by uid 22791); 6 Aug 2011 14:15:08 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,T_FRT_FREE X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 06 Aug 2011 14:14:47 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p76EEjtF021696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 6 Aug 2011 10:14:45 -0400 Received: from host1.jankratochvil.net (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p76EEhH8010163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Aug 2011 10:14:45 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p76EEga1003855; Sat, 6 Aug 2011 16:14:42 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p76EEfmp003854; Sat, 6 Aug 2011 16:14:41 +0200 Date: Sat, 06 Aug 2011 14:15:00 -0000 From: Jan Kratochvil To: Daniel Jacobowitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [patch] Make test-cp-name-parser usable Message-ID: <20110806141441.GA2668@host1.jankratochvil.net> References: <20110802170152.GA24932@host1.jankratochvil.net> <20110804095121.GA4486@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00129.txt.bz2 On Fri, 05 Aug 2011 22:18:50 +0200, Daniel Jacobowitz wrote: > Thanks! I appreciate it. You might want an explanatory comment, this > looks sufficiently odd. It's OK with me either way. Checked in with the comment. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2011-08/msg00036.html --- src/gdb/ChangeLog 2011/08/05 16:38:34 1.13256 +++ src/gdb/ChangeLog 2011/08/06 14:13:48 1.13257 @@ -1,3 +1,8 @@ +2011-08-06 Jan Kratochvil + + * cp-name-parser.y (xfree): Wrap the name free by CONCAT2. + (main): Uncomment "Demangling error\n". + 2011-08-05 Paul Pluzhnikov * solib-target.c (segment_attributes): Make them static. --- src/gdb/cp-name-parser.y 2011/03/18 13:51:41 1.20 +++ src/gdb/cp-name-parser.y 2011/08/06 14:13:49 1.21 @@ -2042,7 +2042,10 @@ xfree (void *ptr) { if (ptr != NULL) - free (ptr); + { + /* Literal `free' would get translated back to xfree again. */ + CONCAT2 (fr,ee) (ptr); + } } int @@ -2071,7 +2074,7 @@ str2 = cplus_demangle (buf, DMGL_PARAMS | DMGL_ANSI | DMGL_VERBOSE); if (str2 == NULL) { - /* printf ("Demangling error\n"); */ + printf ("Demangling error\n"); if (c) printf ("%s%c%s\n", buf, c, extra_chars); else