From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25380 invoked by alias); 3 Aug 2011 20:37:04 -0000 Received: (qmail 25242 invoked by uid 22791); 3 Aug 2011 20:37:04 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ey0-f169.google.com (HELO mail-ey0-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Aug 2011 20:36:50 +0000 Received: by eye22 with SMTP id 22so541313eye.0 for ; Wed, 03 Aug 2011 13:36:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.97.144 with SMTP id t16mr295364eef.139.1312403809078; Wed, 03 Aug 2011 13:36:49 -0700 (PDT) Received: by 10.14.127.201 with HTTP; Wed, 3 Aug 2011 13:36:49 -0700 (PDT) In-Reply-To: <20110802170152.GA24932@host1.jankratochvil.net> References: <20110802170152.GA24932@host1.jankratochvil.net> Date: Wed, 03 Aug 2011 20:37:00 -0000 Message-ID: Subject: Re: [patch] Make test-cp-name-parser usable From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00059.txt.bz2 On Tue, Aug 2, 2011 at 1:01 PM, Jan Kratochvil wrote: > gdb/ > 2011-08-02 =A0Jan Kratochvil =A0 > > =A0 =A0 =A0 =A0* cp-name-parser.y (xfree): Remove the call of free. > =A0 =A0 =A0 =A0(main): Uncomment "Demangling error\n". OK. > --- a/gdb/cp-name-parser.y > +++ b/gdb/cp-name-parser.y > @@ -2036,13 +2036,12 @@ trim_chars (char *lexptr, char **extra_chars) > =A0} > > =A0/* When this file is built as a standalone program, xmalloc comes from > - =A0 libiberty --- in which case we have to provide xfree ourselves. =A0= */ > + =A0 libiberty --- in which case we have to provide xfree ourselves. > + =A0 A call to free would get translated xfree back again. =A0Leak is OK= . =A0*/ "translated back to xfree again" What does the translation - is it as simple as #undef free or (free) (ptr)? --=20 Thanks, Daniel