Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Justin Lebar <jlebar@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix documentation for Type.template_argument.
Date: Mon, 07 Jul 2014 17:29:00 -0000	[thread overview]
Message-ID: <CAMuNMfp6A+cbdeWgKnN6aw55qxgpDKX==8wJNGKmUjyaXKeaZA@mail.gmail.com> (raw)
In-Reply-To: <83wqbpchgz.fsf@gnu.org>

> I'm not away, I just remembered that I already reviewed this patch and
> responded with the review on the same day.

Indeed, and although there may have been a problem with the list, I
got your response and sent a fixed patch.  But maybe I misunderstood
your response?

> Otherwise, the patch is OK Texinfo-wise; I don't know enough about
> these issues to tell whether the content is correct

I thought this indicated I should wait for someone else to chime in?
Or were you saying this was OK to submit with this change?

Sorry, I'm obviously new here.  :)

-Justin

On Mon, Jul 7, 2014 at 8:32 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 7 Jul 2014 07:42:50 -0700
>> From: Joel Brobecker <brobecker@adacore.com>
>> Cc: gdb-patches@sourceware.org
>>
>> > Ping on this patch?  (Would it be appropriate to find the last person
>> > to touch this documentation and cc him/her, or do something else like
>> > that?)
>>
>> No, Eli is the person to review this patch, not the last person to
>> touch it. Maybe he is away at the moment.
>
> I'm not away, I just remembered that I already reviewed this patch and
> responded with the review on the same day.
>
> It looks now that my response didn't make it to the list for some
> reason, because I see it in my FCC archive, but not in the list
> archives.
>
> So here's my response as I wrote it back then:
>
>   > From: Justin Lebar <jlebar@google.com>
>   > Cc: Justin Lebar <jlebar@google.com>
>   > Date: Tue, 24 Jun 2014 12:01:36 -0700
>   >
>   > -If this @code{gdb.Type} is not a template type, this will throw an
>   > -exception.  Ordinarily, only C@t{++} code will have template types.
>   > +If this @code{gdb.Type} is not a template type, or if the type has fewer
>   > +than N template arguments, this will throw an exception.  Ordinarily,
>           ^
>   @var{n}
>
>   Otherwise, the patch is OK Texinfo-wise; I don't know enough about
>   these issues to tell whether the content is correct, nor can I answer
>   your question.
>
>   Thanks.
>


  reply	other threads:[~2014-07-07 17:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 22:38 Justin Lebar
2014-07-06 17:57 ` Justin Lebar
2014-07-07 14:42   ` Joel Brobecker
2014-07-07 15:32     ` Eli Zaretskii
2014-07-07 17:29       ` Justin Lebar [this message]
2014-07-07 17:44         ` Eli Zaretskii
2014-08-17 18:25           ` Doug Evans
2014-09-02 22:13             ` Justin Lebar
2014-09-02 22:24               ` Doug Evans
2014-09-03 23:44                 ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuNMfp6A+cbdeWgKnN6aw55qxgpDKX==8wJNGKmUjyaXKeaZA@mail.gmail.com' \
    --to=jlebar@google.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox