From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20431 invoked by alias); 7 Jul 2014 17:29:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20405 invoked by uid 89); 7 Jul 2014 17:29:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f182.google.com Received: from mail-qc0-f182.google.com (HELO mail-qc0-f182.google.com) (209.85.216.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 07 Jul 2014 17:29:20 +0000 Received: by mail-qc0-f182.google.com with SMTP id m20so4064013qcx.41 for ; Mon, 07 Jul 2014 10:29:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=ExYAUYB4FqyvwDcGmZl8rEVxJscd8FoSYhXJPMfhUVQ=; b=RjjSQDw9e8aY5tsBFoMEki1+2SAdFxC/WdwKVBPDuWP5+N0b8lorMPT+AUwiV78Wz6 z51hfr1+zQSrIv6LaZJ5djD+5PHmzP0T/SVV3MbfX9w6YPS9vpXvMyz9dCnQfvDjhcJ0 kGM9yCvfoJaZ32445d5a04Z3Y/90ZJ1O890xhSKZInGBWVHkgSIXlyOtxQcFQlZocPxq Ow2IAd0kemQMj0IGMjTbWQYmKiQq9J8ToJhJQpEQlBijt3XW0lGdjelwgOC0Xdqynmde +5rJeRMH4y1rvdpivI3+inu/CPWCPmYUeTt9MjeFdEXUqpErTvvi7Vx1y7XjQSrrHn9r kswA== X-Gm-Message-State: ALoCoQlwBV8BbixAgBuErK5fYq2dL2aAkFJGYhXOG85f3UbbEKJ8Dl99ory7AlqlGRtY0kN2/KZn X-Received: by 10.140.101.245 with SMTP id u108mr24526875qge.48.1404754158719; Mon, 07 Jul 2014 10:29:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.96.44.193 with HTTP; Mon, 7 Jul 2014 10:28:58 -0700 (PDT) In-Reply-To: <83wqbpchgz.fsf@gnu.org> References: <1403649524-10769-1-git-send-email-jlebar@google.com> <20140707144250.GE6038@adacore.com> <83wqbpchgz.fsf@gnu.org> From: Justin Lebar Date: Mon, 07 Jul 2014 17:29:00 -0000 Message-ID: Subject: Re: [PATCH v2] Fix documentation for Type.template_argument. To: Eli Zaretskii Cc: Joel Brobecker , gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-07/txt/msg00129.txt.bz2 > I'm not away, I just remembered that I already reviewed this patch and > responded with the review on the same day. Indeed, and although there may have been a problem with the list, I got your response and sent a fixed patch. But maybe I misunderstood your response? > Otherwise, the patch is OK Texinfo-wise; I don't know enough about > these issues to tell whether the content is correct I thought this indicated I should wait for someone else to chime in? Or were you saying this was OK to submit with this change? Sorry, I'm obviously new here. :) -Justin On Mon, Jul 7, 2014 at 8:32 AM, Eli Zaretskii wrote: >> Date: Mon, 7 Jul 2014 07:42:50 -0700 >> From: Joel Brobecker >> Cc: gdb-patches@sourceware.org >> >> > Ping on this patch? (Would it be appropriate to find the last person >> > to touch this documentation and cc him/her, or do something else like >> > that?) >> >> No, Eli is the person to review this patch, not the last person to >> touch it. Maybe he is away at the moment. > > I'm not away, I just remembered that I already reviewed this patch and > responded with the review on the same day. > > It looks now that my response didn't make it to the list for some > reason, because I see it in my FCC archive, but not in the list > archives. > > So here's my response as I wrote it back then: > > > From: Justin Lebar > > Cc: Justin Lebar > > Date: Tue, 24 Jun 2014 12:01:36 -0700 > > > > -If this @code{gdb.Type} is not a template type, this will throw an > > -exception. Ordinarily, only C@t{++} code will have template types. > > +If this @code{gdb.Type} is not a template type, or if the type has fewer > > +than N template arguments, this will throw an exception. Ordinarily, > ^ > @var{n} > > Otherwise, the patch is OK Texinfo-wise; I don't know enough about > these issues to tell whether the content is correct, nor can I answer > your question. > > Thanks. >