From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: jlebar@google.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix documentation for Type.template_argument.
Date: Mon, 07 Jul 2014 15:32:00 -0000 [thread overview]
Message-ID: <83wqbpchgz.fsf@gnu.org> (raw)
In-Reply-To: <20140707144250.GE6038@adacore.com>
> Date: Mon, 7 Jul 2014 07:42:50 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> > Ping on this patch? (Would it be appropriate to find the last person
> > to touch this documentation and cc him/her, or do something else like
> > that?)
>
> No, Eli is the person to review this patch, not the last person to
> touch it. Maybe he is away at the moment.
I'm not away, I just remembered that I already reviewed this patch and
responded with the review on the same day.
It looks now that my response didn't make it to the list for some
reason, because I see it in my FCC archive, but not in the list
archives.
So here's my response as I wrote it back then:
> From: Justin Lebar <jlebar@google.com>
> Cc: Justin Lebar <jlebar@google.com>
> Date: Tue, 24 Jun 2014 12:01:36 -0700
>
> -If this @code{gdb.Type} is not a template type, this will throw an
> -exception. Ordinarily, only C@t{++} code will have template types.
> +If this @code{gdb.Type} is not a template type, or if the type has fewer
> +than N template arguments, this will throw an exception. Ordinarily,
^
@var{n}
Otherwise, the patch is OK Texinfo-wise; I don't know enough about
these issues to tell whether the content is correct, nor can I answer
your question.
Thanks.
next prev parent reply other threads:[~2014-07-07 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 22:38 Justin Lebar
2014-07-06 17:57 ` Justin Lebar
2014-07-07 14:42 ` Joel Brobecker
2014-07-07 15:32 ` Eli Zaretskii [this message]
2014-07-07 17:29 ` Justin Lebar
2014-07-07 17:44 ` Eli Zaretskii
2014-08-17 18:25 ` Doug Evans
2014-09-02 22:13 ` Justin Lebar
2014-09-02 22:24 ` Doug Evans
2014-09-03 23:44 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wqbpchgz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jlebar@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox