From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-114019-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24921 invoked by alias); 7 Jul 2014 15:32:39 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 24884 invoked by uid 89); 7 Jul 2014 15:32:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout26.012.net.il
Received: from mtaout26.012.net.il (HELO mtaout26.012.net.il) (80.179.55.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Jul 2014 15:32:36 +0000
Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0N8C00900LKYJS00@mtaout26.012.net.il> for gdb-patches@sourceware.org; Mon, 07 Jul 2014 18:28:21 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8C00179LN9UR80@mtaout26.012.net.il>; Mon, 07 Jul 2014 18:28:21 +0300 (IDT)
Date: Mon, 07 Jul 2014 15:32:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2] Fix documentation for Type.template_argument.
In-reply-to: <20140707144250.GE6038@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: jlebar@google.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83wqbpchgz.fsf@gnu.org>
References: <1403649524-10769-1-git-send-email-jlebar@google.com> <CAMuNMfouo1ZX5GNx2T5Sk0HEb9AiY7spYgur-cXZeJCeduMB3g@mail.gmail.com> <20140707144250.GE6038@adacore.com>
X-IsSubscribed: yes
X-SW-Source: 2014-07/txt/msg00124.txt.bz2

> Date: Mon, 7 Jul 2014 07:42:50 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> > Ping on this patch?  (Would it be appropriate to find the last person
> > to touch this documentation and cc him/her, or do something else like
> > that?)
> 
> No, Eli is the person to review this patch, not the last person to
> touch it. Maybe he is away at the moment.

I'm not away, I just remembered that I already reviewed this patch and
responded with the review on the same day.

It looks now that my response didn't make it to the list for some
reason, because I see it in my FCC archive, but not in the list
archives.

So here's my response as I wrote it back then:

  > From: Justin Lebar <jlebar@google.com>
  > Cc: Justin Lebar <jlebar@google.com>
  > Date: Tue, 24 Jun 2014 12:01:36 -0700
  >
  > -If this @code{gdb.Type} is not a template type, this will throw an
  > -exception.  Ordinarily, only C@t{++} code will have template types.
  > +If this @code{gdb.Type} is not a template type, or if the type has fewer
  > +than N template arguments, this will throw an exception.  Ordinarily,
	  ^
  @var{n}

  Otherwise, the patch is OK Texinfo-wise; I don't know enough about
  these issues to tell whether the content is correct, nor can I answer
  your question.

  Thanks.