Re: [PATCHv3 0/8] x86/Linux Target Description Changes

["H.J. Lu" <hjl.tools@gmail.com>]

On Tue, Mar 26, 2024 at 5:16 AM Andrew Burgess <aburgess@redhat.com> wrote:
>
> Simon Marchi <simark@simark.ca> writes:
>
> > On 3/25/24 13:20, Andrew Burgess wrote:
> >> Andrew Burgess <aburgess@redhat.com> writes:
> >>
> >>> In v3:
> >>>
> >>>   - Rebased.  Nasty merge conflict with 4bb20a6244b7091 which I think
> >>>     I've resolved, but am unable to test.  Reposting so the author of
> >>>     that other commit can validate.
> >>>
> >>>   - Initial testing looks good.  Full tests are still running.
> >>
> >> Testing completed with no issues.  H.J. Lu confirmed that this versions
> >> didn't break the x32 behaviour.  I've gone ahead and pushed these
> >> patches.
> >>
> >> If anything crops up then do let me know.
> >>
> >> Thanks,
> >> Andrew
> >>
> >
> > Hi Andrew,
> >
> > I think your series introduces some build failures with Clang.  One is
> > easy, it's a missing `-x c++` in gdbserver/Makefile.in.
>
> Thanks for fixing this one.
>
> >
> > The other is:
> >
> >       CXX    nat/x86-linux-tdesc-ipa.o
> >     /home/smarchi/src/binutils-gdb/gdbserver/../gdb/nat/x86-linux-tdesc.c:167:1: error: unused function 'x86_linux_i386_tdesc_feature_mask' [-Werror,-Wunused-function]
> >       167 | x86_linux_i386_tdesc_feature_mask ()
> >           | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > It's possible that this function just needs to be moved in the same
> > "#ifdef" as where it's used, but since I didn't follow your work
> > closely, I prefer to let you fix it, in case I'm missing something.
>
> Sorry for the breakage.
>
> I pushed the patch below to resolve this issue.
>

gdbserver from your old patch:

https://patchwork.sourceware.org/project/gdb/list/?series=32189

works on x32.  But the current master gives me:

/export/gnu/import/git/sources/gdb/gdbserver/regcache.cc:273: A
problem internal to GDBserver has been detected.
Unknown register bnd0raw requested

again.

-- 
H.J.