From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KCsUNALTAmYV4RYAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 09:52:02 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=XlF6p1vd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D040D1E0C0; Tue, 26 Mar 2024 09:52:02 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B55141E030 for ; Tue, 26 Mar 2024 09:52:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 30F2F385841E for ; Tue, 26 Mar 2024 13:52:00 +0000 (GMT) Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by sourceware.org (Postfix) with ESMTPS id B24733858C56 for ; Tue, 26 Mar 2024 13:51:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B24733858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B24733858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711461100; cv=none; b=obuxc899D9yyVJ123iu/JnKkTrVhPf6znlxUqPWFWt1Vdapbm+ciOHAsi8RMEDfvYU5reZL7ZGCU+xOyNV7cpTpqsN6x43NkCuRQga6+7MbO/6UJWBiYfzrv7h3Pa1LN7S6ScXY0dr20QqOk1FhQ1ZeKmusg+NSgH9fS6ThTsPM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711461100; c=relaxed/simple; bh=XzNiWEfempVP9yUP+9JBQC0Dmn4Ni6Drsw0+2u2d+44=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=gw0zC5sCUvDo03Bou/TKje/8dDijVLZu4IXjOP/u4TDfwNTdzLTMBQJnZmWhgXIvOoYRCCujOdwF3jJ4YdmMgGjFi92KfawL8B0IsDjdv4L4O8X2ZMHO/Fh91AGSqNZb4+IIg1vj42NY1ImByaytU7jIYdmf89UZdiaDOLaOyaU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-609f1f97864so63304657b3.0 for ; Tue, 26 Mar 2024 06:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711461098; x=1712065898; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2Z8gkJ+Y59/fI6NxWWQhLyrwER24lHCyW5+J9gcVH1E=; b=XlF6p1vdqHk0+RBjTisUyD8fldj5LmXzo+enZ8nbmwBSxxpeX+PFm+tIH3bNoqqTQs ldzVptNKqP3Np2Yfbx942rlBboa8lkRx/vpRNx5CfQ44QBx2wsD3+mYAfbQpGTuVTxXl Xrp0+ROowiOr4WgeMTjzGXMWjMclAD53eKxI5Qk3btTfjbdB/Vpu8DRRlBemZ0YS9MJ4 OfbWwcD8sHQOQZNImv1GJj3TsXt+45coltJSgVzUM9yN+yFYdlSoxANZSQjATe7sv/9L if8yp4WavW4xbvHAo1tjXVJ5JeFqJYiYDS10NvIUe89qdusbjxvEpt2pvHhijPx3VjoC p2Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711461098; x=1712065898; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Z8gkJ+Y59/fI6NxWWQhLyrwER24lHCyW5+J9gcVH1E=; b=k7NvFXi7UzCFMjtDs6glHvO2XkYlCxxC8YNsaY5ROGcN/ZbCJQoH4VyytKHusdmlZP 4xb7Ki7zTrs5azQbW4wguZIXklmvx5E9DBSPAvRc/llJnOb7ysPbixrnw2zkZaZIj0kJ 2ejUux270XWD1HcvyWAAmtzeDJTJGeP57hIY3f2gFFeHf76kBLBq1EFPwsmSOEA6/iJT dnru6hrb5LKaqMlyrWZ96ebrb3ksQEm1j1Z6Ax80BfdqqwcaavxTMcsJPncrsI+Puo6+ XhSmnJMlpTscMFuti4mtItB4qrLmTURzNFuBKGx20BzT5cVTVIuazeY//7bT8yY67c/V 3rMQ== X-Forwarded-Encrypted: i=1; AJvYcCVyI2LkAbDPdXZsh7aYUUyimlOtUkGt9hxyqb6JFUbxxUtpf612NN1U5EXJKovDfLzA0z261x1zfLGawHAQCD9upOM04yG4IASUJA== X-Gm-Message-State: AOJu0Yw81anEdM75xaWxtrVymRheT938xUoZqQmCnpFZyMCy9xl12X+E 7z2VbXz4+MdLkY8scYgbyM7XenwSCkX3fIMpBNaUz4mn7leumwQ4nPy9Dxh7yEUGaPFqc5CxiDa 2pOgzknvpnHq93KvJYwfvTamAT45eER0e688= X-Google-Smtp-Source: AGHT+IGWTXehDuySFdm6AMJfBj6GN1An3LyqVnFaQZeFrWYOlPFnIOOEHR5nBidclzurpC+OpkmPMvNcS17cwznw5GU= X-Received: by 2002:a81:7c8b:0:b0:610:ce53:e274 with SMTP id x133-20020a817c8b000000b00610ce53e274mr9403427ywc.14.1711461097776; Tue, 26 Mar 2024 06:51:37 -0700 (PDT) MIME-Version: 1.0 References: <8734seteht.fsf@redhat.com> <413a66aa-e035-41cf-9af4-040685f89204@simark.ca> <87a5ml5gu8.fsf@redhat.com> In-Reply-To: <87a5ml5gu8.fsf@redhat.com> From: "H.J. Lu" Date: Tue, 26 Mar 2024 06:51:01 -0700 Message-ID: Subject: Re: [PATCHv3 0/8] x86/Linux Target Description Changes To: Andrew Burgess Cc: Simon Marchi , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Tue, Mar 26, 2024 at 5:16=E2=80=AFAM Andrew Burgess wrote: > > Simon Marchi writes: > > > On 3/25/24 13:20, Andrew Burgess wrote: > >> Andrew Burgess writes: > >> > >>> In v3: > >>> > >>> - Rebased. Nasty merge conflict with 4bb20a6244b7091 which I think > >>> I've resolved, but am unable to test. Reposting so the author of > >>> that other commit can validate. > >>> > >>> - Initial testing looks good. Full tests are still running. > >> > >> Testing completed with no issues. H.J. Lu confirmed that this version= s > >> didn't break the x32 behaviour. I've gone ahead and pushed these > >> patches. > >> > >> If anything crops up then do let me know. > >> > >> Thanks, > >> Andrew > >> > > > > Hi Andrew, > > > > I think your series introduces some build failures with Clang. One is > > easy, it's a missing `-x c++` in gdbserver/Makefile.in. > > Thanks for fixing this one. > > > > > The other is: > > > > CXX nat/x86-linux-tdesc-ipa.o > > /home/smarchi/src/binutils-gdb/gdbserver/../gdb/nat/x86-linux-tdesc= .c:167:1: error: unused function 'x86_linux_i386_tdesc_feature_mask' [-Werr= or,-Wunused-function] > > 167 | x86_linux_i386_tdesc_feature_mask () > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > It's possible that this function just needs to be moved in the same > > "#ifdef" as where it's used, but since I didn't follow your work > > closely, I prefer to let you fix it, in case I'm missing something. > > Sorry for the breakage. > > I pushed the patch below to resolve this issue. > gdbserver from your old patch: https://patchwork.sourceware.org/project/gdb/list/?series=3D32189 works on x32. But the current master gives me: /export/gnu/import/git/sources/gdb/gdbserver/regcache.cc:273: A problem internal to GDBserver has been detected. Unknown register bnd0raw requested again. --=20 H.J.