Re: [PATCHv3 0/8] x86/Linux Target Description Changes

[Andrew Burgess <aburgess@redhat.com>]

Andrew Burgess <aburgess@redhat.com> writes:

> Andrew Burgess <aburgess@redhat.com> writes:
>
>> Andrew Burgess <aburgess@redhat.com> writes:
>>
>>> In v3:
>>>
>>>   - Rebased.  Nasty merge conflict with 4bb20a6244b7091 which I think
>>>     I've resolved, but am unable to test.  Reposting so the author of
>>>     that other commit can validate.
>>>
>>>   - Initial testing looks good.  Full tests are still running.
>>
>> Testing completed with no issues.  H.J. Lu confirmed that this versions
>> didn't break the x32 behaviour.  I've gone ahead and pushed these
>> patches.
>>
>> If anything crops up then do let me know.
>
> I'm aware that this series broke pretty much anything that was not x86
> based when configured with --enable-targets=all.
>
> The problem is that, as part of this commit, I moved generic tdep (arch
> specific) code into the nat/ directory as part of an effort to share the
> code between GDB and gdbserver.  This was incorrect.
>
> I'm open to reverting this series, however, I'm currently working on a
> fix, splitting the nat/ code between nat/ and arch/.  I'm hoping to have
> a fix today.  If that doesn't look possible then I'll likely revert this
> series before the end of my day.
>
> Apologies for the (serious) breakage.

I have now reverted all of the commits from this series, as well as the
small fixes which I pushed earlier today.  I've also reverts the fix
which Simon pushed that was for code from this series.

Splitting the code between nat/ and arch/ mostly worked, but I was still
running into some edge cases which I couldn't get working, so I could
either:

  + push a partial fix, which still left some things broken, or

  + revert everything, take a step back and re-work the series.

I think reverting and coming at this fresh tomorrow is the better
choice.

I apologise for all the churn.  The post-revert branch seemed to build
fine, so hopefully I've not left anything in a broken state.

Let me know if I've left anything broken, I'll check back in a couple of
hours to see if there is more fixing needed.

Thanks,
Andrew