From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ei/hJhccA2YhPBcAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 15:03:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HWnJbGh8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 827BC1E0C0; Tue, 26 Mar 2024 15:03:51 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 61B7A1E08C for ; Tue, 26 Mar 2024 15:03:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9D3C4385840C for ; Tue, 26 Mar 2024 19:03:48 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 060BE3858CDA for ; Tue, 26 Mar 2024 19:03:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 060BE3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 060BE3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711479810; cv=none; b=PlpEKy4j6xNy4P1hAp6VjKLh7tljESFQbTa6DZXIfeZKPTJtKnNggXHqFAMGtKHkgaxDqrmYJeGYtn58oFOmdLng0NW0SG7qIaBMjuWqdOUu+vfccO84G+gxkqt9uWAhbBHhiFO01jXL3xHpjclT4gkVZ/y/7NGqJAXi4OdVRek= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711479810; c=relaxed/simple; bh=iLsJyVREpNK7jJzyv88fmRugM5U36yGmFpnitewlIv4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CL+ZD+wiu6SoGxNArT7OJhIwW9/li17yT1CpLu9V7bjWCuLz8wo9FPNx0BgKw7qs5UQK7Z2bLZO7XN9q6xQ2GsHTOR94jB6KY96eCyeTpO3fsDV58SQyf43tzgWOjyuBpCFZ2VzH97aaVIpwg4WDJ8J6C/B+JjrHMf2omChEn+I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711479799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6b8mpIZJepU8932evmsi5g1Kx2zbOAi32QinDeW4D/g=; b=HWnJbGh8KGZzCaBL3eMrvf777eyF7CoKDayX+sAMpAmNfbTfq0fo0ZEWZwErdPXxoEjpQN +8v6LiSz0TNvzA0Z+IKDs37yoxFiD6itt+oKi/s9NhZ2WPreZ1sSdm5+2GtWjEblEuLqkN uEz1xhq3bOnH52NeXEkiVS4dOoLu3j0= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-huyHjEVeO5W51pfdot--SA-1; Tue, 26 Mar 2024 15:03:17 -0400 X-MC-Unique: huyHjEVeO5W51pfdot--SA-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a45acc7f07cso326462366b.2 for ; Tue, 26 Mar 2024 12:03:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711479796; x=1712084596; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6b8mpIZJepU8932evmsi5g1Kx2zbOAi32QinDeW4D/g=; b=INRMp5tkxxPOv7CM57iBAxTIHOSqn+mUbft6pRYvdAcv45j2c7JCrcAIi0Hv2t8gX6 Jpd3MFa4GN4UVyD3ojhmqBc2hHldRIcjXrGF54/yKi1Urk9JMOu7Pi6Wu+9pH2H3qbX/ 5cJjI0IlTTo04sha5rij1FlhkfC3s7OfECuojlSDk7itIu9iZ5YgQd6QWImIBSrfoV9+ GIuCJx5JAe0P9UYwpEFxDuTf98kfJMHOgFeZimx640OBbYCO26WZtoUHhnC1C7eSQW7b 7B0niJezUESRSDBAVTHnp8hRRrtw4vYmUjBpGli7sjdy12Ky8LT8M4iMH7sYHSe04eyn Ewrg== X-Gm-Message-State: AOJu0Yz/uC5Lt8kAIaLUcmuyKhSKF8KdwmSk4wDGm7gApp9HfwlquSRT vVR4oVnk/ajsyAQn9U8EarFO7uU/5ZuTgMVoPBERcTK4kWVYR1mcpFvkPQgG0grAf+UhfzPmNlh mVEzttcjNfUBk9dEMsz79XvkoBuTeYbS3Uy2li+/3HM/pqUNFbE3DgfmBOAYY8ny6Dnumttv2/A LYe2Nz9zynXLt5jvT05kh+ITxZWiXm/WFF5I2ECj0Hqoc= X-Received: by 2002:a17:906:3b98:b0:a4a:ba53:27a6 with SMTP id u24-20020a1709063b9800b00a4aba5327a6mr2772787ejf.46.1711479795894; Tue, 26 Mar 2024 12:03:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYrPMfHxTeSqpQ6VdGObhVOgi6yLCKHAS64EQT2uWGVJbOVVnHv0rjha2YFPppYwoi4rDGxw== X-Received: by 2002:a17:906:3b98:b0:a4a:ba53:27a6 with SMTP id u24-20020a1709063b9800b00a4aba5327a6mr2772765ejf.46.1711479795314; Tue, 26 Mar 2024 12:03:15 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id z3-20020a170906668300b00a4750a4a1f7sm3339532ejo.6.2024.03.26.12.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 12:03:15 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: hjl.tools@gmail.com Subject: Re: [PATCHv3 0/8] x86/Linux Target Description Changes In-Reply-To: <874jct54sn.fsf@redhat.com> References: <8734seteht.fsf@redhat.com> <874jct54sn.fsf@redhat.com> Date: Tue, 26 Mar 2024 19:03:14 +0000 Message-ID: <871q7w6cjx.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Andrew Burgess writes: > Andrew Burgess writes: > >> Andrew Burgess writes: >> >>> In v3: >>> >>> - Rebased. Nasty merge conflict with 4bb20a6244b7091 which I think >>> I've resolved, but am unable to test. Reposting so the author of >>> that other commit can validate. >>> >>> - Initial testing looks good. Full tests are still running. >> >> Testing completed with no issues. H.J. Lu confirmed that this versions >> didn't break the x32 behaviour. I've gone ahead and pushed these >> patches. >> >> If anything crops up then do let me know. > > I'm aware that this series broke pretty much anything that was not x86 > based when configured with --enable-targets=all. > > The problem is that, as part of this commit, I moved generic tdep (arch > specific) code into the nat/ directory as part of an effort to share the > code between GDB and gdbserver. This was incorrect. > > I'm open to reverting this series, however, I'm currently working on a > fix, splitting the nat/ code between nat/ and arch/. I'm hoping to have > a fix today. If that doesn't look possible then I'll likely revert this > series before the end of my day. > > Apologies for the (serious) breakage. I have now reverted all of the commits from this series, as well as the small fixes which I pushed earlier today. I've also reverts the fix which Simon pushed that was for code from this series. Splitting the code between nat/ and arch/ mostly worked, but I was still running into some edge cases which I couldn't get working, so I could either: + push a partial fix, which still left some things broken, or + revert everything, take a step back and re-work the series. I think reverting and coming at this fresh tomorrow is the better choice. I apologise for all the churn. The post-revert branch seemed to build fine, so hopefully I've not left anything in a broken state. Let me know if I've left anything broken, I'll check back in a couple of hours to see if there is more fixing needed. Thanks, Andrew