From: "H.J. Lu" <hjl.tools@gmail.com>
To: Aaron Merey <amerey@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, Simon Marchi <simark@simark.ca>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Aaron Merey via Binutils <binutils@sourceware.org>,
GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES
Date: Sat, 25 Jul 2020 09:01:05 -0700 [thread overview]
Message-ID: <CAMe9rOo2phYZYFSZR-uDqUF5vCNGZmCoh0-rcMqDVp14nEKScQ@mail.gmail.com> (raw)
In-Reply-To: <CAJDtP-TSiS1=xeVxefCzu3EbfJFL29-K_nTNw0Y7b-DZoSs2aA@mail.gmail.com>
On Fri, Jul 24, 2020 at 1:04 PM Aaron Merey via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Tue, Jul 21, 2020 at 2:11 PM Aaron Merey <amerey@redhat.com> wrote:
> >
> > On Tue, Jul 21, 2020 at 11:20 AM Tom Tromey <tom@tromey.com> wrote:
> > >
> > > Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put the include
> > > Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac?
> > >
> > > Simon> Otherwise, from GDB's point of view I think it looks good, unless
> > > Simon> Tom has some things to add.
> > >
> > > I'm happy with it. Thanks for persevering.
> >
> > Great. I can push to binutils-gdb but not gcc. Should I just push to
> > binutils-gdb for now or wait until the patch can be applied to both
> > repos at once?
>
> I'm going to go ahead and push to binutils-gdb. Since these changes
> should not affect gcc there shouldn't be any conflicts.
>
This caused:
https://sourceware.org/bugzilla/show_bug.cgi?id=26301
--
H.J.
next prev parent reply other threads:[~2020-07-25 16:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200502022903.175852-1-amerey@redhat.com>
[not found] ` <3d9da16939fa6b503188033b56d30531e03d5d2a.camel@redhat.com>
2020-05-05 21:23 ` Aaron Merey
2020-05-08 20:56 ` Tom Tromey
2020-07-16 22:17 ` Aaron Merey
2020-07-16 22:37 ` Aaron Merey
2020-07-19 15:43 ` Simon Marchi
2020-07-21 15:20 ` Tom Tromey
2020-07-21 18:11 ` Aaron Merey
2020-07-24 20:03 ` Aaron Merey
2020-07-25 16:01 ` H.J. Lu [this message]
2020-07-27 15:31 ` [PATCH] config/debuginfod.m4: Restore AC_CHECK_LIB check H.J. Lu
2020-07-27 16:11 ` Aaron Merey
2020-07-27 19:14 ` [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works H.J. Lu
2020-07-27 19:32 ` V2 " H.J. Lu
2020-07-28 10:45 ` H.J. Lu
2020-07-28 12:46 ` Simon Marchi
2020-07-28 13:33 ` H.J. Lu
2020-07-28 13:51 ` Andreas Schwab
2020-07-28 13:56 ` H.J. Lu
2020-07-28 14:01 ` Simon Marchi
2020-07-28 14:11 ` H.J. Lu
2020-07-28 14:34 ` Simon Marchi
2020-07-28 15:05 ` H.J. Lu
2020-07-28 15:13 ` Simon Marchi
2020-07-28 16:07 ` H.J. Lu
2020-07-28 16:28 ` Simon Marchi
2020-07-28 17:26 ` H.J. Lu
2020-07-28 17:43 ` Simon Marchi
2020-07-28 18:31 ` H.J. Lu
2020-07-28 18:47 ` Simon Marchi
2020-07-28 18:57 ` H.J. Lu
2020-07-28 14:54 ` Andreas Schwab
2020-07-28 13:53 ` H.J. Lu
2020-07-28 13:54 ` Simon Marchi
2020-07-28 12:54 ` Mark Wielaard
2020-07-28 13:27 ` [PATCH] PKG_CHECK_MODULES: Properly check " H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOo2phYZYFSZR-uDqUF5vCNGZmCoh0-rcMqDVp14nEKScQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=amerey@redhat.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox