From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by sourceware.org (Postfix) with ESMTPS id C2C5F3850432; Sat, 25 Jul 2020 16:01:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C2C5F3850432 Received: by mail-il1-x141.google.com with SMTP id a11so9682805ilk.0; Sat, 25 Jul 2020 09:01:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RKngpD5OQ7ISybbTH4OdfBNVD3i2JOp34aFSYp+Z8bc=; b=MNBLyPU5Hr/DtolxZIxikh7gDbhwMXVK2+euqFR1VBdBa9k4NOTBLT3mBrY8NTCpVu hgRm8VVeXINM1QLz5B8C9hYVqtL/5ieQzK9iSzF31kkudw46I6fwA8R04wIQQLj3e4Iw XUvbjAAvWB45sEwX0zSyTP/oSuLGAXDCJeeMaizYxSS+q2W0dNcBHslqIWLxfNMji3ep M/uUGE1zpB/qqlfQnCZIgyPW+6pGs3ez+IUXRGmZ+otc2m+HMpo+oYdXRPG6zp3sqnOy 9osY2JeRXM2NSvj1wFEymJ5ua/T2v2iBrWPxRPawVfK2tQk/v1MkDdvZ/322b1r6nV0Q OMcg== X-Gm-Message-State: AOAM531zNNmxheeF0bLJT6ySUpYoB/9fhmQAFfMCO/tcRqphCFzc43Ek OCGbovpTbzmVYkCWQGhLexDJWxFpDrDybD0FJu0= X-Google-Smtp-Source: ABdhPJwWF1BVpnAiDfoHLnNpJ9e6mry8For7e5qJeReV8gNljIGAScFJg2VDs75CR1KOfWd4T8Uo8jbLjk8Qv4kdbos= X-Received: by 2002:a92:cf42:: with SMTP id c2mr9332698ilr.13.1595692901225; Sat, 25 Jul 2020 09:01:41 -0700 (PDT) MIME-Version: 1.0 References: <20200502022903.175852-1-amerey@redhat.com> <3d9da16939fa6b503188033b56d30531e03d5d2a.camel@redhat.com> <87a72ino27.fsf@tromey.com> <64517fee-8b8f-84b2-a116-c3d146ff1119@simark.ca> <87eep4hp3s.fsf@tromey.com> In-Reply-To: From: "H.J. Lu" Date: Sat, 25 Jul 2020 09:01:05 -0700 Message-ID: Subject: Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES To: Aaron Merey Cc: Tom Tromey , Simon Marchi , GCC Patches , Aaron Merey via Binutils , GDB Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2020 16:01:43 -0000 On Fri, Jul 24, 2020 at 1:04 PM Aaron Merey via Gcc-patches wrote: > > On Tue, Jul 21, 2020 at 2:11 PM Aaron Merey wrote: > > > > On Tue, Jul 21, 2020 at 11:20 AM Tom Tromey wrote: > > > > > > Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put the include > > > Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac? > > > > > > Simon> Otherwise, from GDB's point of view I think it looks good, unless > > > Simon> Tom has some things to add. > > > > > > I'm happy with it. Thanks for persevering. > > > > Great. I can push to binutils-gdb but not gcc. Should I just push to > > binutils-gdb for now or wait until the patch can be applied to both > > repos at once? > > I'm going to go ahead and push to binutils-gdb. Since these changes > should not affect gcc there shouldn't be any conflicts. > This caused: https://sourceware.org/bugzilla/show_bug.cgi?id=26301 -- H.J.