From: "Paul Pluzhnikov via gdb-patches" <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>,
Paul Pluzhnikov via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch][gdb] Fix crashes in bz24364
Date: Mon, 17 Jun 2019 20:57:00 -0000 [thread overview]
Message-ID: <CALoOobPpLt=4o2nwPw6A-7nL9wDsUicWZgsSkB2HH=obY0yZoQ@mail.gmail.com> (raw)
In-Reply-To: <79db104da967cc2ef9ca4bf85a004bed@polymtl.ca>
Simon,
On Mon, Jun 17, 2019 at 12:31 PM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> On 2019-06-17 13:38, Tom Tromey wrote:
> >>>>>> "Paul" == Paul Pluzhnikov via gdb-patches
> >>>>>> <gdb-patches@sourceware.org> writes:
> >
> > Paul> This is somewhat on the obvious side.
> > Paul> Fix all crashes from bz24364.
> >
> > Paul> gdb/ChangeLog
> >
> > Paul> PR gdb/24364
> > Paul> * gdb/dtrace-probe.c
> > (dtrace_static_probe_ops::get_probe): Don't
> > Paul> call dtrace_process_dof with NULL dof.
> >
> > Thank you for the patch. This is ok.
> >
> > Tom
>
> Could you please just change the commit title to state what is changed
> concretely?
I've already committed this patch, but I'd like to understand your
request for the future.
What changed concretely is that we don't call dtrace_process_dof()
with NULL dof anymore. I am not sure how to express this clearer.
> Also, put in the commit message at least a small example of
> how to trigger the bug.
To trigger the bug, run gdb on any of the examples attached to bugzilla 24364.
They are all artificial (generated by fuzzing).
Cheers,
--
Paul Pluzhnikov
next prev parent reply other threads:[~2019-06-17 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 14:42 Paul Pluzhnikov via gdb-patches
2019-06-17 17:39 ` Tom Tromey
2019-06-17 19:32 ` Simon Marchi
2019-06-17 20:57 ` Paul Pluzhnikov via gdb-patches [this message]
2019-06-17 21:08 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALoOobPpLt=4o2nwPw6A-7nL9wDsUicWZgsSkB2HH=obY0yZoQ@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox