Re: [patch][gdb] Fix crashes in bz24364

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2019-06-17 4:56 p.m., Paul Pluzhnikov wrote:
> I've already committed this patch, but I'd like to understand your
> request for the future.
> 
> What changed concretely is that we don't call dtrace_process_dof()
> with NULL dof anymore. I am not sure how to express this clearer.

Ah, my bad.  It's just that usually, the email subject is also the commit title,
so I thought that "Fix crashes in bz24364" would end up as the commit message.  I
see that it is "PR gdb/24364: Don't call dtrace_process_dof with NULL dof." in
reality, this is fine.

>>  Also, put in the commit message at least a small example of
>> how to trigger the bug.
> 
> To trigger the bug, run gdb on any of the examples attached to bugzilla 24364.
> They are all artificial (generated by fuzzing).

When possible I find it useful to give a summary of the bug in the commit message
(including the steps that lead to the crash).  It makes it much easier to find the
information when doing archaeology than having to refer to the bugzilla (especially
that the bugzilla may not be there forever).  Although with a fuzzed binary it's not
as obvious, since you can't really describe the binary (though we could add a
test with it).

Simon