From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88655 invoked by alias); 17 Jun 2019 21:08:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88646 invoked by uid 89); 17 Jun 2019 21:08:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 spammy=UD:p.m, p.m, pm X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jun 2019 21:08:30 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x5HL8LGo003924 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2019 17:08:26 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x5HL8LGo003924 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1560805707; bh=VnOc7cFnbSmbPZCgodLr2UvPcrWlVKN7c+gyTsPkRcY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=aP6O4CE7fhdOFHSD/BgVvLJJ1iRFC3Yl6iX1Bmy0dw+gxN/vPqkzK4MZZvxDOAUDW 4XV5HF8WQnFIcS9hLDCNosdVD4X/K4tPeEnzoMd3nQgDoz/f2urLoPfsKxmdd2jpTf VR1KxdJDpk8XvmDsd5zKpm0KPWCSEqB9H6j+vFJM= Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A99CC1E05A; Mon, 17 Jun 2019 17:08:21 -0400 (EDT) Subject: Re: [patch][gdb] Fix crashes in bz24364 To: Paul Pluzhnikov Cc: Tom Tromey , Paul Pluzhnikov via gdb-patches References: <87ef3skt70.fsf@tromey.com> <79db104da967cc2ef9ca4bf85a004bed@polymtl.ca> From: Simon Marchi Message-ID: <28871991-83f0-dbac-7988-b29b0b58c9ce@polymtl.ca> Date: Mon, 17 Jun 2019 21:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00318.txt.bz2 On 2019-06-17 4:56 p.m., Paul Pluzhnikov wrote: > I've already committed this patch, but I'd like to understand your > request for the future. > > What changed concretely is that we don't call dtrace_process_dof() > with NULL dof anymore. I am not sure how to express this clearer. Ah, my bad. It's just that usually, the email subject is also the commit title, so I thought that "Fix crashes in bz24364" would end up as the commit message. I see that it is "PR gdb/24364: Don't call dtrace_process_dof with NULL dof." in reality, this is fine. >> Also, put in the commit message at least a small example of >> how to trigger the bug. > > To trigger the bug, run gdb on any of the examples attached to bugzilla 24364. > They are all artificial (generated by fuzzing). When possible I find it useful to give a summary of the bug in the commit message (including the steps that lead to the crash). It makes it much easier to find the information when doing archaeology than having to refer to the bugzilla (especially that the bugzilla may not be there forever). Although with a fuzzed binary it's not as obvious, since you can't really describe the binary (though we could add a test with it). Simon