From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71713 invoked by alias); 17 Jun 2019 20:57:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71662 invoked by uid 89); 17 Jun 2019 20:57:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.1 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=no version=3.3.1 spammy=U*gdb-patches, gdbpatchessourcewareorg, sk:gdb-pat, gdb-patches@sourceware.org X-HELO: mail-vs1-f66.google.com Received: from mail-vs1-f66.google.com (HELO mail-vs1-f66.google.com) (209.85.217.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jun 2019 20:57:13 +0000 Received: by mail-vs1-f66.google.com with SMTP id 2so3977485vso.8 for ; Mon, 17 Jun 2019 13:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iMuofRx7PyCAAsPzUSM9Pvh/VN1WCEmpsUoRoECJSnY=; b=g2hR3tQRKfJB8GDZsTQ68L9GDd0Kx8/uC8TxLpdN0n9SdZZB011G/EAnWOr6hNI/cl 9MoqzN8zOi0OXKENO+lVeMcidjq6BYG6Ui5BbeGFFMs0wVIKHUaLrajofrh5UbqBIxJG cOyQ3JoTLGtK+abfBReDxpNPsG30ahP2URWYoqhLbssGh/+MBub3j4goPlH9cXkKTvoO l3uuVqptwjj2wF5IEfxoUoDjxSdSEYBXYDhUAM/FO3Lb1hJZNCcvHXfpv5quo1u5hVrC 3B+l1iaB7N1YEym7EJPwehWK87SJywMlzPmQNSxKzHiDWMmeQuU5d6VHz53XaVyPVNmF 6Efg== MIME-Version: 1.0 References: <87ef3skt70.fsf@tromey.com> <79db104da967cc2ef9ca4bf85a004bed@polymtl.ca> In-Reply-To: <79db104da967cc2ef9ca4bf85a004bed@polymtl.ca> From: "Paul Pluzhnikov via gdb-patches" Reply-To: Paul Pluzhnikov Date: Mon, 17 Jun 2019 20:57:00 -0000 Message-ID: Subject: Re: [patch][gdb] Fix crashes in bz24364 To: Simon Marchi Cc: Tom Tromey , Paul Pluzhnikov via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00317.txt.bz2 Simon, On Mon, Jun 17, 2019 at 12:31 PM Simon Marchi wrote: > > On 2019-06-17 13:38, Tom Tromey wrote: > >>>>>> "Paul" == Paul Pluzhnikov via gdb-patches > >>>>>> writes: > > > > Paul> This is somewhat on the obvious side. > > Paul> Fix all crashes from bz24364. > > > > Paul> gdb/ChangeLog > > > > Paul> PR gdb/24364 > > Paul> * gdb/dtrace-probe.c > > (dtrace_static_probe_ops::get_probe): Don't > > Paul> call dtrace_process_dof with NULL dof. > > > > Thank you for the patch. This is ok. > > > > Tom > > Could you please just change the commit title to state what is changed > concretely? I've already committed this patch, but I'd like to understand your request for the future. What changed concretely is that we don't call dtrace_process_dof() with NULL dof anymore. I am not sure how to express this clearer. > Also, put in the commit message at least a small example of > how to trigger the bug. To trigger the bug, run gdb on any of the examples attached to bugzilla 24364. They are all artificial (generated by fuzzing). Cheers, -- Paul Pluzhnikov