From: Mike Frysinger <vapier@gentoo.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: erc32: fix linking against local readline on modern (ncurses) systems
Date: Sat, 31 Dec 2011 02:57:00 -0000 [thread overview]
Message-ID: <CAJaTeTqguQX877CVXz3D=0=10CF2t8OODTEYMt1awCSC09RJXQ@mail.gmail.com> (raw)
In-Reply-To: <20111230101842.GA13974@adacore.com>
On Fri, Dec 30, 2011 at 05:18, Joel Brobecker wrote:
>> 2011-12-30 Mike Frysinger <vapier@gentoo.org>
>>
>> * configure.ac: Change AC_CHECK_LIB to AC_SEARCH_LIBS, and add
>> ncurses/curses to the library search list.
>> * configure: Regenerated.
> [...]
>> - AC_CHECK_LIB(termcap, main, TERMCAP=-ltermcap, TERMCAP="")
>> + AC_SEARCH_LIBS(tputs, ncurses curses termcap,
>> + [TERMCAP=$ac_cv_search_tputs], [TERMCAP=""])
>
> Is this going to hurt on non-GNU/Linux systems? In particular,
> you have chosen an order that is different from the order selected
> in GDB:
i hadn't noticed GDB had a test for it. i'm fine with keeping the two in sync.
maybe extract the termcap m4 code out of gdb and put into a new m4
file in the top level config/ dir ? that way we'd know the two trees
would stay in sync.
-mike
next prev parent reply other threads:[~2011-12-31 2:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 10:19 Mike Frysinger
2011-12-30 10:39 ` Joel Brobecker
2011-12-31 2:57 ` Mike Frysinger [this message]
2011-12-31 3:39 ` Joel Brobecker
2011-12-31 7:27 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJaTeTqguQX877CVXz3D=0=10CF2t8OODTEYMt1awCSC09RJXQ@mail.gmail.com' \
--to=vapier@gentoo.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox