From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: erc32: fix linking against local readline on modern (ncurses) systems
Date: Fri, 30 Dec 2011 10:39:00 -0000 [thread overview]
Message-ID: <20111230101842.GA13974@adacore.com> (raw)
In-Reply-To: <1325238201-7982-1-git-send-email-vapier@gentoo.org>
> 2011-12-30 Mike Frysinger <vapier@gentoo.org>
>
> * configure.ac: Change AC_CHECK_LIB to AC_SEARCH_LIBS, and add
> ncurses/curses to the library search list.
> * configure: Regenerated.
[...]
> - AC_CHECK_LIB(termcap, main, TERMCAP=-ltermcap, TERMCAP="")
> + AC_SEARCH_LIBS(tputs, ncurses curses termcap,
> + [TERMCAP=$ac_cv_search_tputs], [TERMCAP=""])
Is this going to hurt on non-GNU/Linux systems? In particular,
you have chosen an order that is different from the order selected
in GDB:
# These are the libraries checked by Readline.
AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncurses])
On platform providing both termcap and curses, GDB will choose
termcap while the sim will likely choose termcap, and we'll end
up trying to link with both!
Can you try using the same check as in GDB? Do you have to check
for tputs, or does checking for tgetent have the same effect?
Otherwise, can you try at least checking the libraries in the same
order as in GDB?
--
Joel
next prev parent reply other threads:[~2011-12-30 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 10:19 Mike Frysinger
2011-12-30 10:39 ` Joel Brobecker [this message]
2011-12-31 2:57 ` Mike Frysinger
2011-12-31 3:39 ` Joel Brobecker
2011-12-31 7:27 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111230101842.GA13974@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox