From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14990 invoked by alias); 31 Dec 2011 02:56:05 -0000 Received: (qmail 14981 invoked by uid 22791); 31 Dec 2011 02:56:04 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 31 Dec 2011 02:55:50 +0000 Received: by iacb35 with SMTP id b35so28532153iac.0 for ; Fri, 30 Dec 2011 18:55:50 -0800 (PST) Received: by 10.42.151.65 with SMTP id d1mr42234847icw.18.1325300150282; Fri, 30 Dec 2011 18:55:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.173.66 with HTTP; Fri, 30 Dec 2011 18:55:29 -0800 (PST) In-Reply-To: <20111230101842.GA13974@adacore.com> References: <1325238201-7982-1-git-send-email-vapier@gentoo.org> <20111230101842.GA13974@adacore.com> From: Mike Frysinger Date: Sat, 31 Dec 2011 02:57:00 -0000 Message-ID: Subject: Re: [PATCH] sim: erc32: fix linking against local readline on modern (ncurses) systems To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00910.txt.bz2 On Fri, Dec 30, 2011 at 05:18, Joel Brobecker wrote: >> 2011-12-30 =A0Mike Frysinger =A0 >> >> =A0 =A0 =A0 * configure.ac: Change AC_CHECK_LIB to AC_SEARCH_LIBS, and a= dd >> =A0 =A0 =A0 ncurses/curses to the library search list. >> =A0 =A0 =A0 * configure: Regenerated. > [...] >> - =A0AC_CHECK_LIB(termcap, main, TERMCAP=3D-ltermcap, TERMCAP=3D"") >> + =A0AC_SEARCH_LIBS(tputs, ncurses curses termcap, >> + =A0 =A0[TERMCAP=3D$ac_cv_search_tputs], [TERMCAP=3D""]) > > Is this going to hurt on non-GNU/Linux systems? In particular, > you have chosen an order that is different from the order selected > in GDB: i hadn't noticed GDB had a test for it. i'm fine with keeping the two in s= ync. maybe extract the termcap m4 code out of gdb and put into a new m4 file in the top level config/ dir ? that way we'd know the two trees would stay in sync. -mike