From: Aaron Merey <amerey@redhat.com>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH v4] Add debuginfod support to GDB
Date: Mon, 24 Feb 2020 20:46:00 -0000 [thread overview]
Message-ID: <CAJDtP-R6M_wMQHE944NPyD+7ngLFxS4SDbkS3ydv81oF=2x5-w@mail.gmail.com> (raw)
In-Reply-To: <e1f6b60b-bc69-228d-a318-128a18e42b68@simark.ca>
On Mon, Feb 24, 2020 at 3:39 PM Simon Marchi <simark@simark.ca> wrote:
> I just noticed that the debuginfod_debuginfo_query definition is not in sync with
> the declaration, so when we build without debug info support, we get:
>
> CXX debuginfod-support.o
> /home/smarchi/src/binutils-gdb/gdb/debuginfod-support.c: In function ‘scoped_fd debuginfod_debuginfo_query(const unsigned char*, int, gdb::unique_xmalloc_ptr<char>*)’:
> /home/smarchi/src/binutils-gdb/gdb/debuginfod-support.c:36:1: error: no previous declaration for ‘scoped_fd debuginfod_debuginfo_query(const unsigned char*, int, gdb::unique_xmalloc
> _ptr<char>*)’ [-Werror=missing-declarations]
> debuginfod_debuginfo_query (const unsigned char *build_id __attribute__((unused)),
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> I also think you could remove the __attribute__((unused)). We don't use -Wunused-parameter
> in GDB, and I don't think we plan to (there are a ton of places with unused parameters like
> that, that don't hurt).
Ah ok I will change that on my end, I won't repost the patch over that unless
you'd like me to.
Aaron
next prev parent reply other threads:[~2020-02-24 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 1:58 Aaron Merey
2020-02-21 20:12 ` Simon Marchi
2020-02-24 4:43 ` Aaron Merey
2020-02-24 20:39 ` Simon Marchi
2020-02-24 20:46 ` Aaron Merey [this message]
2020-02-24 20:49 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJDtP-R6M_wMQHE944NPyD+7ngLFxS4SDbkS3ydv81oF=2x5-w@mail.gmail.com' \
--to=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox