From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96560 invoked by alias); 24 Feb 2020 20:46:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96551 invoked by uid 89); 24 Feb 2020 20:46:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*f:sk:e1f6b60, H*i:sk:e1f6b60 X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Feb 2020 20:46:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582577168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qxz8yOm7Qo6ov4ONKU5jg2vAC8/C8SUQIyxkl792Hds=; b=F0auBHyqCi2uNmVXJA/Cb+QFBNyMXD6TnMRPmTmHSNUylEW/UC+s3TarSvXdb3U3KvQqwj cVxKGDg1MrqCMUU1LmulkbhWbvRJ+bAWDHf9FIu5CqS6EsR8yOGOZk6X2/890uIZGQezce AuXwuARK8KmtEtSeo0OZ/bIVP3eeMY0= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-FpdVok8mOoq6yyNCeUyh7g-1; Mon, 24 Feb 2020 15:46:07 -0500 Received: by mail-vs1-f71.google.com with SMTP id x71so895220vsx.13 for ; Mon, 24 Feb 2020 12:46:07 -0800 (PST) MIME-Version: 1.0 References: <1282d65e-5c1c-a7d8-b29d-24dd8036ae2d@simark.ca> In-Reply-To: From: Aaron Merey Date: Mon, 24 Feb 2020 20:46:00 -0000 Message-ID: Subject: Re: [PATCH v4] Add debuginfod support to GDB To: Simon Marchi Cc: gdb-patches@sourceware.org, Tom Tromey X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2020-02/txt/msg00932.txt.bz2 On Mon, Feb 24, 2020 at 3:39 PM Simon Marchi wrote: > I just noticed that the debuginfod_debuginfo_query definition is not in s= ync with > the declaration, so when we build without debug info support, we get: > > CXX debuginfod-support.o > /home/smarchi/src/binutils-gdb/gdb/debuginfod-support.c: In function =E2= =80=98scoped_fd debuginfod_debuginfo_query(const unsigned char*, int, gdb::= unique_xmalloc_ptr*)=E2=80=99: > /home/smarchi/src/binutils-gdb/gdb/debuginfod-support.c:36:1: error: no p= revious declaration for =E2=80=98scoped_fd debuginfod_debuginfo_query(const= unsigned char*, int, gdb::unique_xmalloc > _ptr*)=E2=80=99 [-Werror=3Dmissing-declarations] > debuginfod_debuginfo_query (const unsigned char *build_id __attribute__(= (unused)), > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > I also think you could remove the __attribute__((unused)). We don't use = -Wunused-parameter > in GDB, and I don't think we plan to (there are a ton of places with unus= ed parameters like > that, that don't hurt). Ah ok I will change that on my end, I won't repost the patch over that unle= ss you'd like me to. Aaron