Re: [PATCH v4] Add debuginfod support to GDB

[Simon Marchi <simark@simark.ca>]

On 2020-02-20 8:57 p.m., Aaron Merey wrote:
> Hello,
> 
> In this iteration of the patch I've modified the debuginfod
> progress function so that it does not preserve the value
> of quit_flag when the user enters ctrl+c. Progress
> updates now print the completion percentage of the
> download. Additional help text is also printed before and
> after a query which provides context for what file is being
> searched for and whether the download was successful.
> 
> On IRC we discussed changing the behavior of ctrl+c
> during a download depending on whether an inferior
> is running. This change will come in a future patch at
> some point before the next release.
> 
> Aaron
> 

I'll have to build debuginfod and configure it, so I can give it a try
and see how it files.

In the mean time: if we fail to parse the server's response as a bfd or
if the build id doesn't match, I think we need to display a warning,
because it probably means that the server sent us something bad, or there
was some problem somewhere in the pipeline.

Currently, if that happens, the user would see "Download successful", but
no debug info loaded, so it's a bit misleading.

Simon