From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39551 invoked by alias); 21 Feb 2020 20:12:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39542 invoked by uid 89); 21 Feb 2020 20:12:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=misleading, H*r:172.16.0, server's X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2020 20:12:05 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CD7961E5FA; Fri, 21 Feb 2020 15:12:03 -0500 (EST) Subject: Re: [PATCH v4] Add debuginfod support to GDB To: Aaron Merey , gdb-patches@sourceware.org Cc: Tom Tromey References: From: Simon Marchi Message-ID: <1282d65e-5c1c-a7d8-b29d-24dd8036ae2d@simark.ca> Date: Fri, 21 Feb 2020 20:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00863.txt.bz2 On 2020-02-20 8:57 p.m., Aaron Merey wrote: > Hello, > > In this iteration of the patch I've modified the debuginfod > progress function so that it does not preserve the value > of quit_flag when the user enters ctrl+c. Progress > updates now print the completion percentage of the > download. Additional help text is also printed before and > after a query which provides context for what file is being > searched for and whether the download was successful. > > On IRC we discussed changing the behavior of ctrl+c > during a download depending on whether an inferior > is running. This change will come in a future patch at > some point before the next release. > > Aaron > I'll have to build debuginfod and configure it, so I can give it a try and see how it files. In the mean time: if we fail to parse the server's response as a bfd or if the build id doesn't match, I think we need to display a warning, because it probably means that the server sent us something bad, or there was some problem somewhere in the pipeline. Currently, if that happens, the user would see "Download successful", but no debug info loaded, so it's a bit misleading. Simon