Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aaron Merey <amerey@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/1] Add debuginfod support to GDB
Date: Fri, 10 Jan 2020 16:46:00 -0000	[thread overview]
Message-ID: <CAJDtP-QtT9FrOXGrLhdJJJgBqFwdOTk_RVUx9a_QMCApJVzDuw@mail.gmail.com> (raw)
In-Reply-To: <87tv53wfub.fsf@tromey.com>

On Fri, Jan 10, 2020 at 9:23 AM Tom Tromey <tom@tromey.com> wrote:
> Ok.  Well, if you want to keep that, then you'll also have to submit the
> top-level changes to GCC and get them approved there.  gcc and
> binutils-gdb share the top-level configury.  It's canonically maintained
> in the gcc repository; on occasion we do land a patch in binutils-gdb
> first, but normally the process is to land there first.

Ok good to know. Like you said it's more convenient to have debuginfod.m4
local to gdb. But since the binutils configury uses it too, maybe it's worth
submitting this change to GCC to minimize duplication.

> >> A lot of this code is duplicated in 3 places.  I think it would be
> >> better to have a helper function to consolidate the shared code.
>
> Aaron> Agreed, is gdb/gdbsupport/ a good place for this helper?
>
> No, since gdbserver won't use this code.

Ok how about gdb/debuginfod-support.h then?

Aaron


  parent reply	other threads:[~2020-01-10 16:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09  3:48 Aaron Merey
2020-01-09 13:48 ` Eli Zaretskii
     [not found] ` <87h814r6p4.fsf@tromey.com>
2020-01-09 22:41   ` Aaron Merey
2020-01-09 23:28     ` Christian Biesinger via gdb-patches
2020-01-10 16:32       ` Aaron Merey
     [not found]     ` <87tv53wfub.fsf@tromey.com>
2020-01-10 16:46       ` Aaron Merey [this message]
2020-01-10 18:43         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJDtP-QtT9FrOXGrLhdJJJgBqFwdOTk_RVUx9a_QMCApJVzDuw@mail.gmail.com \
    --to=amerey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox