From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84249 invoked by alias); 10 Jan 2020 16:46:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84182 invoked by uid 89); 10 Jan 2020 16:46:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=submitting X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2020 16:46:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578674775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l29Nkk97zSM8X9fbxAe2Du7h2XkTfsXRdolYOYNYRFM=; b=Cw9lJgHsecFwNwAuyCkd5lYPhBQdgkdqpMhI32USxZl07lrsNvFVofrTyqEyWJIzNfAhvk xhs/xSIUmVERkqwbn4uZ7qlixBswFpnk1MIzMfevBPlJEgwH4cevv/qmszOUUBI54fVDKi KtF9G+FgMr5aatzPXHukmRICCW7246w= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-HIx8RxluOoCpxYk1Kifo8w-1; Fri, 10 Jan 2020 11:46:13 -0500 Received: by mail-ua1-f72.google.com with SMTP id 71so616280uae.22 for ; Fri, 10 Jan 2020 08:46:13 -0800 (PST) MIME-Version: 1.0 References: <87h814r6p4.fsf@tromey.com> <87tv53wfub.fsf@tromey.com> In-Reply-To: <87tv53wfub.fsf@tromey.com> From: Aaron Merey Date: Fri, 10 Jan 2020 16:46:00 -0000 Message-ID: Subject: Re: [PATCH 1/1] Add debuginfod support to GDB To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2020-01/txt/msg00256.txt.bz2 On Fri, Jan 10, 2020 at 9:23 AM Tom Tromey wrote: > Ok. Well, if you want to keep that, then you'll also have to submit the > top-level changes to GCC and get them approved there. gcc and > binutils-gdb share the top-level configury. It's canonically maintained > in the gcc repository; on occasion we do land a patch in binutils-gdb > first, but normally the process is to land there first. Ok good to know. Like you said it's more convenient to have debuginfod.m4 local to gdb. But since the binutils configury uses it too, maybe it's worth submitting this change to GCC to minimize duplication. > >> A lot of this code is duplicated in 3 places. I think it would be > >> better to have a helper function to consolidate the shared code. > > Aaron> Agreed, is gdb/gdbsupport/ a good place for this helper? > > No, since gdbserver won't use this code. Ok how about gdb/debuginfod-support.h then? Aaron