From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <pedro@codesourcery.com>
Subject: Re: [PATCH 034/238] [misc.] Fix -Wshadow warnings.
Date: Mon, 05 Dec 2011 13:27:00 -0000 [thread overview]
Message-ID: <CAHQ1cqH+fTNU3mtvw-woHuv4nn5ti3UR-pqKFbRGsq_DDiPukQ@mail.gmail.com> (raw)
In-Reply-To: <20111205113032.GK2777@adacore.com>
On Mon, Dec 5, 2011 at 6:30 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> * breakpoint.c (update_static_tracepoint): Rename `sal' to
>> `sal2'(-Wshadow).
>
> Looks OK to me. But Pedro might comment on the new variable name
> (sal->sal2).
This name change was suggested by Stan, see
http://sourceware.org/ml/gdb-patches/2011-11/msg00609.html
Initially it was sal->las which probably isn't better, so I'll wait
for some consensus to arise on this patch too.
> (weird mis-alignment of the ChangeLog, but I assume that'll be fixed
> by the time it gets inserted in the ChangeLog file).
I have to edit ChangeLog by hands anyway, so the diffs for it are just
the relics of how I initially made commits. To answer your question:
yes it'll either be fixed or I erroneously weirdly mis-align it even
more :)
Andrey Smirnov
next prev parent reply other threads:[~2011-12-05 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:25 [PATCH 35/358] Fix -Wsahdow warnings Andrey Smirnov
2011-11-22 19:19 ` Tom Tromey
2011-11-23 0:35 ` Stan Shebs
2011-11-23 4:46 ` Andrey Smirnov
2011-11-28 15:19 ` [PATCH 034/238] [misc.] Fix -Wshadow warnings Andrey Smirnov
2011-12-05 11:30 ` Joel Brobecker
2011-12-05 13:27 ` Andrey Smirnov [this message]
2011-12-05 13:31 ` Joel Brobecker
2011-12-06 18:25 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHQ1cqH+fTNU3mtvw-woHuv4nn5ti3UR-pqKFbRGsq_DDiPukQ@mail.gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox