From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17407 invoked by alias); 5 Dec 2011 13:17:50 -0000 Received: (qmail 17399 invoked by uid 22791); 5 Dec 2011 13:17:49 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 13:17:36 +0000 Received: by iapp10 with SMTP id p10so6642593iap.0 for ; Mon, 05 Dec 2011 05:17:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.21.234 with SMTP id k42mr710619ibb.46.1323091054999; Mon, 05 Dec 2011 05:17:34 -0800 (PST) Received: by 10.50.237.74 with HTTP; Mon, 5 Dec 2011 05:17:34 -0800 (PST) In-Reply-To: <20111205113032.GK2777@adacore.com> References: <4ECC3FD2.1000309@earthlink.net> <1322493561-29643-1-git-send-email-andrew.smirnov@gmail.com> <20111205113032.GK2777@adacore.com> Date: Mon, 05 Dec 2011 13:27:00 -0000 Message-ID: Subject: Re: [PATCH 034/238] [misc.] Fix -Wshadow warnings. From: Andrey Smirnov To: Joel Brobecker Cc: gdb-patches@sourceware.org, Pedro Alves Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00134.txt.bz2 On Mon, Dec 5, 2011 at 6:30 PM, Joel Brobecker wrot= e: >> =A0 =A0 =A0 * breakpoint.c (update_static_tracepoint): Rename `sal' to >> =A0 =A0 =A0 =A0 =A0 `sal2'(-Wshadow). > > Looks OK to me. But Pedro might comment on the new variable name > (sal->sal2). This name change was suggested by Stan, see http://sourceware.org/ml/gdb-patches/2011-11/msg00609.html Initially it was sal->las which probably isn't better, so I'll wait for some consensus to arise on this patch too. > (weird mis-alignment of the ChangeLog, but I assume that'll be fixed > by the time it gets inserted in the ChangeLog file). I have to edit ChangeLog by hands anyway, so the diffs for it are just the relics of how I initially made commits. To answer your question: yes it'll either be fixed or I erroneously weirdly mis-align it even more :) Andrey Smirnov