From: Joel Brobecker <brobecker@adacore.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <pedro@codesourcery.com>
Subject: Re: [PATCH 034/238] [misc.] Fix -Wshadow warnings.
Date: Mon, 05 Dec 2011 13:31:00 -0000 [thread overview]
Message-ID: <20111205132646.GA3430@adacore.com> (raw)
In-Reply-To: <CAHQ1cqH+fTNU3mtvw-woHuv4nn5ti3UR-pqKFbRGsq_DDiPukQ@mail.gmail.com>
> > Looks OK to me. But Pedro might comment on the new variable name
> > (sal->sal2).
[...]
> Initially it was sal->las which probably isn't better, so I'll wait
> for some consensus to arise on this patch too.
FWIW, I'm OK with sal2. I also agree with stan that it's best to
avoid `las' (cute, though :-))
--
Joel
next prev parent reply other threads:[~2011-12-05 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:25 [PATCH 35/358] Fix -Wsahdow warnings Andrey Smirnov
2011-11-22 19:19 ` Tom Tromey
2011-11-23 0:35 ` Stan Shebs
2011-11-23 4:46 ` Andrey Smirnov
2011-11-28 15:19 ` [PATCH 034/238] [misc.] Fix -Wshadow warnings Andrey Smirnov
2011-12-05 11:30 ` Joel Brobecker
2011-12-05 13:27 ` Andrey Smirnov
2011-12-05 13:31 ` Joel Brobecker [this message]
2011-12-06 18:25 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205132646.GA3430@adacore.com \
--to=brobecker@adacore.com \
--cc=andrew.smirnov@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox