From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85816-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20756 invoked by alias); 5 Dec 2011 13:27:04 -0000
Received: (qmail 20748 invoked by uid 22791); 5 Dec 2011 13:27:04 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 13:26:49 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 2A66F2BB05D;	Mon,  5 Dec 2011 08:26:49 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id gipYeU+oCgQT; Mon,  5 Dec 2011 08:26:49 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id F14C82BAFBD;	Mon,  5 Dec 2011 08:26:48 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000)	id B5173145615; Mon,  5 Dec 2011 05:26:46 -0800 (PST)
Date: Mon, 05 Dec 2011 13:31:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <pedro@codesourcery.com>
Subject: Re: [PATCH 034/238] [misc.] Fix -Wshadow warnings.
Message-ID: <20111205132646.GA3430@adacore.com>
References: <4ECC3FD2.1000309@earthlink.net> <1322493561-29643-1-git-send-email-andrew.smirnov@gmail.com> <20111205113032.GK2777@adacore.com> <CAHQ1cqH+fTNU3mtvw-woHuv4nn5ti3UR-pqKFbRGsq_DDiPukQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHQ1cqH+fTNU3mtvw-woHuv4nn5ti3UR-pqKFbRGsq_DDiPukQ@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00135.txt.bz2

> > Looks OK to me. But Pedro might comment on the new variable name
> > (sal->sal2).
[...]
> Initially it was sal->las which probably isn't better, so I'll wait
> for some consensus to arise on this patch too.

FWIW, I'm OK with sal2. I also agree with stan that it's best to
avoid `las' (cute, though :-))

-- 
Joel