[PATCH 1/348] Fix -Wshadow errors

[PATCH 1/348] Fix -Wshadow errors

[Andrey Smirnov]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Hello everybody,

Since my paperwork with copyright assignemnt is done. I'd like to move
on with patches I originally proposed in
http://sourceware.org/ml/gdb-patches/2011-11/msg00004.html. I split
original files into smaller ones, so that each patch affects only one
function. The patches are rebased against commit
4a30c67183563e8d66c86805bde0c73bcf02e3ee in
git://sourceware.org/git/gdb.git

Andrey Smirnov

P.S. Not sure if some sort of conformation of aforementioned paperwork
is required of me or is it a responsibility of a maintainer. Feel free
to contact me if it is the former.

[-- Attachment #2: 0001-gdb-ada-exp.y.patch --]
[-- Type: text/x-patch, Size: 885 bytes --]

From 94eebb235f4741927a3c701472fa8ead6a3f9af0 Mon Sep 17 00:00:00 2001
From: Andrey Smirnov <andrew.smirnov@gmail.com>
Date: Wed, 2 Nov 2011 20:14:04 +0700
Subject: [PATCH 001/353] gdb/ada-exp.y

---
 gdb/ada-exp.y |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y
index 9576be5..bfa3913 100644
--- a/gdb/ada-exp.y
+++ b/gdb/ada-exp.y
@@ -1287,12 +1287,12 @@ write_var_or_type (struct block *block, struct stoken name0)
 	     FIXME pnh 7/20/2007. */
 	  if (nsyms == 1)
 	    {
-	      struct symbol *renaming =
+	      struct symbol *ren_sym =
 		ada_find_renaming_symbol (SYMBOL_LINKAGE_NAME (syms[0].sym), 
 					  syms[0].block);
 
-	      if (renaming != NULL)
-		syms[0].sym = renaming;
+	      if (ren_sym != NULL)
+		syms[0].sym = ren_sym;
 	    }
 
 	  type_sym = select_possible_type_sym (syms, nsyms);
-- 
1.7.5.4

Re: [PATCH 1/348] Fix -Wshadow errors

[Joel Brobecker]

Andrey,

> ---
>  gdb/ada-exp.y |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

This change is OK, but we need a ChangeLog entry for it. As soon as
you've resubmitted it with the ChangeLog entry, we can give you write
access to the GDB repository, and you'll be able to commit the approved
patches yourself.

If you haven't already done so, please read the gdb/CONTRIBUTE file...

Generally speaking, we also expect all changes to be validated against
our testsuite. This means running the testsuite before and after the
patch, and making sure that new failures did not appear in the meantime.

> 
> diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y
> index 9576be5..bfa3913 100644
> --- a/gdb/ada-exp.y
> +++ b/gdb/ada-exp.y
> @@ -1287,12 +1287,12 @@ write_var_or_type (struct block *block, struct stoken name0)
>  	     FIXME pnh 7/20/2007. */
>  	  if (nsyms == 1)
>  	    {
> -	      struct symbol *renaming =
> +	      struct symbol *ren_sym =
>  		ada_find_renaming_symbol (SYMBOL_LINKAGE_NAME (syms[0].sym), 
>  					  syms[0].block);
>  
> -	      if (renaming != NULL)
> -		syms[0].sym = renaming;
> +	      if (ren_sym != NULL)
> +		syms[0].sym = ren_sym;
>  	    }
>  
>  	  type_sym = select_possible_type_sym (syms, nsyms);
> -- 
> 1.7.5.4
> 


-- 
Joel